-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto update parquets #20
Merged
gosuto-inzasheru
merged 11 commits into
onchainification:dev-nup002-auto-parquets
from
nup002:auto-update_parquets
Mar 15, 2021
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
51953d0
[ADD] Added support for catching other type of connection errors
yo2x 73cde95
Merge pull request #17 from yo2x/feature/Catch_connection_errors
gosuto-inzasheru b212ca2
[FIX] added a timeout of 30 seconds by default
yo2x 2dd79c3
[FIX] some typo
yo2x 3dd0b9a
Merge pull request #19 from yo2x/feature/Catch_connection_errors
gosuto-inzasheru b1281d0
Refactored code to allow for further development.
nup002 8278e80
Added additional user settings to top of Main.py.
nup002 dcbed96
Improved documentation.
nup002 072c8ad
When running in pycharm output is now correctly formatted.
nup002 1dcf8ce
Fixed issue where, rarely, the last received maximum candle time exce…
nup002 b6f4df9
More robust progress bar.
nup002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nup002 can I ask what you are doing here? It seems to introduce a bug where the max of the bar can become higher than what is communicated in line 154 (
total_minutes_of_data
).Wouldn't it be better for consistency to stick to
max(bar.max_value, minutes_covered)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
max(bar.max_value, minutes_covered)
is a much more elegant solution.