Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support verification on tenderly #91

Merged
merged 6 commits into from
Jul 14, 2024
Merged

feat: support verification on tenderly #91

merged 6 commits into from
Jul 14, 2024

Conversation

gosuto-inzasheru
Copy link
Member

closes #90

@gosuto-inzasheru gosuto-inzasheru changed the title Issue/90 feat: support verification on tenderly Jul 10, 2024
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (d9a631d) to head (cc41785).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files           2        2           
  Lines         205      205           
  Branches       33       33           
=======================================
  Hits          203      203           
  Misses          2        2           

@gosuto-inzasheru
Copy link
Member Author

gosuto-inzasheru commented Jul 13, 2024

i opted for a make command to manually verify a vmodule contract address on tenderly, instead of automatically doing it during deployment

verifying on tenderly during deployment is possible, but it would then replace the gnosisscan verification which i think should be prioritised

(note i had to rewind the contract to the v0.1.0 tag and thus rewind #93 in order for the command to work)

Start verifying contract `0x157c21cC4f776C941E20A51DB7b10D6eD4888200` deployed on xdai

Submitting verification for [src/RoboSaverVirtualModule.sol:RoboSaverVirtualModule] 0x157c21cC4f776C941E20A51DB7b10D6eD4888200.
Submitted contract for verification:
	Response: `OK`
	GUID: `0x157c21cc4f776c941e20a51db7b10d6ed4888200`
	URL: https://gnosisscan.io/address/0x157c21cc4f776c941e20a51db7b10d6ed4888200
Contract verification status:
Response: `OK`
Details: `Pass - Verified`
Contract successfully verified

bonus: foundry-rs/book#1241

@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review July 13, 2024 09:14
Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as separate make cmd is fine, as long as we get into that flow of always calling and adding the addy into the .env file 👌

checked the vmodule addy at 0x157c21cc4f776c941e20a51db7b10d6ed4888200 can confirm that it's verified ✅

@gosuto-inzasheru
Copy link
Member Author

yea one improvement here could be to accept cli arguments instead of using env vars for the address (and possibly the contract name)

@gosuto-inzasheru gosuto-inzasheru merged commit cc59174 into main Jul 14, 2024
4 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the issue/90 branch July 14, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: also verify with tenderly on deployment
2 participants