-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support verification on tenderly #91
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 2 2
Lines 205 205
Branches 33 33
=======================================
Hits 203 203
Misses 2 2 |
i opted for a make command to manually verify a vmodule contract address on tenderly, instead of automatically doing it during deployment verifying on tenderly during deployment is possible, but it would then replace the gnosisscan verification which i think should be prioritised (note i had to rewind the contract to the v0.1.0 tag and thus rewind #93 in order for the command to work)
bonus: foundry-rs/book#1241 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as separate make cmd is fine, as long as we get into that flow of always calling and adding the addy into the .env
file 👌
checked the vmodule addy at 0x157c21cc4f776c941e20a51db7b10d6ed4888200 can confirm that it's verified ✅
yea one improvement here could be to accept cli arguments instead of using env vars for the address (and possibly the contract name) |
closes #90