Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qualify the function saturate with q10n:: specifier to prevent ambiguity #1937

Merged
merged 1 commit into from
May 31, 2024

Conversation

quickwritereader
Copy link
Contributor

Description

qualify the function saturate with q10n:: specifier to prevent ambiguity

Fixes #1929

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

Performance improvements

  • Have you submitted performance data that demonstrates performance improvements?

New features

  • Have you published an RFC for the new feature?
  • Was the RFC approved?
  • Have you added relevant tests?

Bug fixes

  • Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • Have you added relevant regression tests?

RFC PR

  • Does RFC document follow the template?
  • Have you added a link to the rendered document?

@vpirogov vpirogov added this to the v3.6 milestone May 30, 2024
@vpirogov vpirogov added the platform:cpu-s390x IBM Z systems based on s390x architecture label May 30, 2024
@vpirogov
Copy link
Member

@kwizart, could you please help confirming this patch addresses the issue?

@kwizart
Copy link
Contributor

kwizart commented May 31, 2024

@kwizart, could you please help confirming this patch addresses the issue?

Yes, it does fix the issue:
https://koji.fedoraproject.org/koji/taskinfo?taskID=118350737

Thanks

@vpirogov
Copy link
Member

Thanks, @kwizart. I'll backport this fix as well so it makes it into oneDNN v3.5.

@vpirogov vpirogov merged commit cfbc413 into oneapi-src:main May 31, 2024
11 checks passed
@vpirogov vpirogov modified the milestones: v3.6, v3.5 May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-s390x IBM Z systems based on s390x architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpu: s390x: build fails with saturate was not declared in this scope
4 participants