Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfcs: add a proposal on MatMul reduction API #2152

Open
wants to merge 2 commits into
base: rfcs
Choose a base branch
from

Conversation

densamoilov
Copy link
Contributor

@densamoilov densamoilov added the RFC A design document label Oct 4, 2024
@densamoilov densamoilov requested a review from a team as a code owner October 4, 2024 21:09
Copy link
Contributor

@mgouicem mgouicem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Denis.
Just a quick comment: it seems there are two problems you are trying to tackle:

  • simplify internals by using matmul under inner-product,
  • and simplify external interface to ditch inner-product.

I would recommend to focus on the first one and keep the matmul extension internal as a first step. We can work on gathering feedback from users for the second part in parallel. What do you think?

Regarding using extension enum and reuse bias_md, that works for me (and much less complex that pre-op/attribute).

@densamoilov
Copy link
Contributor Author

@mgouicem, thanks for the prompt review!

To be precise, the first bullet is the primary goal, while the second represents my thought that the feature could provide value to some users, leading me to suggest making it external. I'm totally fine with making the extensions internal at first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC A design document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants