Avoid __brick_reverse and __brick_reverse_copy calls for empty source data
#1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKopienko
force-pushed
the
dev/skopienko/reverse_pass_fix
branch
from
3e2e9c3
to
25c852f
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/reverse_pass_fix
branch
from
f1ffb63
to
32800c5
Compare
added 3 commits
March 12, 2024 15:37
…for empty source data
…for empty source data
…copy for empty source data
SergeyKopienko
force-pushed
the
dev/skopienko/reverse_pass_fix
branch
from
32800c5
to
e8879ac
Compare
SergeyKopienko
changed the title
reverse.pass testreverse.pass test for empty source data with reverse iterator
SergeyKopienko
changed the title
reverse.pass test for empty source data with reverse iterator__brick_reverse and __brick_reverse_copy calls for empty source data
added 5 commits
March 12, 2024 18:34
…d ';' in 'for' statement specifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assertion happens in the
reverse.passtest.It's reproduced on any C++ compiler on Windows
for CMake line
-DCMAKE_CXX_COMPILER=dpcpp-cl -DCMAKE_BUILD_TYPE=debug -DONEDPL_BACKEND=serialThe root cause is that we call
__brick_reverseand__brick_reverse_copyfor empty source data in the parallel implementations for serial backend.