-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pack __parallel_for
and etc. calls into __internal::__except_handler
#1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKopienko
force-pushed
the
dev/skopienko/fix_parallel_for_calls
branch
from
March 20, 2024 16:41
05797e1
to
f7fca72
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/fix_parallel_for_calls
branch
from
March 20, 2024 17:01
f7fca72
to
6471a42
Compare
SergeyKopienko
changed the title
Pack
Pack Mar 21, 2024
__parallel_for
calls into __internal::__except_handler
__parallel_for
and etc. calls into __internal::__except_handler
…ment: we shouldn't use __except_handler process any exceptions in the files inside include/oneapi/dpl/pstl/hetero folder
…pelling check error
SergeyKopienko
force-pushed
the
dev/skopienko/fix_parallel_for_calls
branch
from
March 21, 2024 13:34
f335733
to
77020ee
Compare
… comments: I believe we dont need usage of __internal::__except_handler in this file.
…s: I believe we dont need usage of __internal::__except_handler in this file.
MikeDvorskiy
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dmitriy-sobolev
pushed a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we pack some parallel function calls into
__internal::__except_handler
:__parallel_find
;__parallel_find_or
;__parallel_for
;__parallel_merge
;__parallel_set_op
;__parallel_set_union_op
;__parallel_stable_sort
.All these changes has been made in all
include/
internal folders, exceptinginclude/oneapi/dpl/pstl/hetero
folder.In the folder
include/oneapi/dpl/pstl/hetero
the call__internal::__except_handler
isn'tn required and removed in two places.