Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack __parallel_for and etc. calls into __internal::__except_handler #1458

Merged
merged 30 commits into from
Mar 21, 2024

Conversation

SergeyKopienko
Copy link
Contributor

@SergeyKopienko SergeyKopienko commented Mar 20, 2024

In this PR we pack some parallel function calls into __internal::__except_handler :

  • __parallel_find;
  • __parallel_find_or;
  • __parallel_for;
  • __parallel_merge;
  • __parallel_set_op;
  • __parallel_set_union_op;
  • __parallel_stable_sort.

All these changes has been made in all include/ internal folders, excepting include/oneapi/dpl/pstl/hetero folder.
In the folder include/oneapi/dpl/pstl/hetero the call __internal::__except_handler isn'tn required and removed in two places.

@SergeyKopienko SergeyKopienko force-pushed the dev/skopienko/fix_parallel_for_calls branch from 05797e1 to f7fca72 Compare March 20, 2024 16:41
@SergeyKopienko SergeyKopienko force-pushed the dev/skopienko/fix_parallel_for_calls branch from f7fca72 to 6471a42 Compare March 20, 2024 17:01
@SergeyKopienko SergeyKopienko marked this pull request as ready for review March 20, 2024 17:02
@SergeyKopienko SergeyKopienko changed the title Pack __parallel_for calls into __internal::__except_handler Pack __parallel_for and etc. calls into __internal::__except_handler Mar 21, 2024
@SergeyKopienko SergeyKopienko force-pushed the dev/skopienko/fix_parallel_for_calls branch from f335733 to 77020ee Compare March 21, 2024 13:34
Sergey Kopienko added 2 commits March 21, 2024 15:21
… comments: I believe we dont need usage of __internal::__except_handler in this file.
…s: I believe we dont need usage of __internal::__except_handler in this file.
Copy link
Contributor

@MikeDvorskiy MikeDvorskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeyKopienko SergeyKopienko merged commit d5cfe25 into main Mar 21, 2024
20 checks passed
@SergeyKopienko SergeyKopienko deleted the dev/skopienko/fix_parallel_for_calls branch March 21, 2024 14:50
@SergeyKopienko SergeyKopienko added this to the 2022.6.0 milestone Mar 21, 2024
SergeyKopienko pushed a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants