Removing noexcept to resolve issue reported by static analysis. #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmichel11
previously requested changes
Mar 22, 2024
SergeyKopienko
requested changes
Mar 22, 2024
…oexcept from forward declaration of __pattern_walk1_n
If the patterns aren't used with functors that perform memory allocation then the noexcept is valid. I'm not looking for a wide removal of the keyword, just removing it where we identify that an exception may indeed be thrown in the use cases we're testing. |
timmiesmith
dismissed
mmichel11’s stale review
Changed were made by @SergeyKopienko to address feedback.
dmitriy-sobolev
pushed a commit
that referenced
this pull request
Mar 22, 2024
--------- Co-authored-by: Sergey Kopienko <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern is used by uninitialized_fill, which uses placement new to created objects, and new may throw a length_error exception. Issue was reported by static analysis tools.