run dr shp-tests #1591
Merged
run dr shp-tests #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haichangsi
force-pushed
the
add_shp_tests
branch
2 times, most recently
from
fe17d1d to
e4ddf13
Compare
haichangsi
force-pushed
the
add_shp_tests
branch
9 times, most recently
from
8043652 to
f562528
Compare
lslusarczyk
requested changes
Jun 7, 2024
There was a problem hiding this comment.
No test was run and even our code did not compile in latest CI run here: https://github.com/oneapi-src/oneDPL/pull/1591/checks
Last compilation error there is
/repo/test/distributed-ranges/shp/../../../include/oneapi/dpl/internal/distributed_ranges_impl/shp/distributed_vector.hpp:14:10: fatal error: 'oneapi/dpl/internal/distributed_ranges_impl/shp/remote_vector.hpp' file not found
14 | #include <oneapi/dpl/internal/distributed_ranges_impl/shp/remote_vector.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
1 error generated.
gmake[3]: *** [test/distributed-ranges/shp/CMakeFiles/shp-tests.dir/build.make:328: test/distributed-ranges/shp/CMakeFiles/shp-tests.dir/algorithms.cpp.o] Error 1
gmake[3]: *** [test/distributed-ranges/shp/CMakeFiles/shp-tests.dir/build.make:342: test/distributed-ranges/shp/CMakeFiles/shp-tests.dir/containers.cpp.o] Error 1
gmake[3]: *** [test/distributed-ranges/shp/CMakeFiles/shp-tests.dir/build.make:356: test/distributed-ranges/shp/CMakeFiles/shp-tests.dir/copy.cpp.o] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:54447: test/distributed-ranges/shp/CMakeFiles/shp-tests.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:54507: test/distributed-ranges/shp/CMakeFiles/shp-all-tests.dir/rule] Error 2
gmake: *** [Makefile:24723: shp-all-tests] Error 2
... but job is green.
- Fix job to be red if compilation fails
- fix dockers to pass
- manually confirm in CI logs that SHP was build and its tests passed
fail because of a merge of the previous PR (renaming a vector) without testing, I'll fix it |
haichangsi
force-pushed
the
add_shp_tests
branch
2 times, most recently
from
46dc5dd to
984abe6
Compare
lslusarczyk
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running DR tests in a docker container for now