[Dynamic Selection] Parallel tests for Dynamic Selection #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace threads.push_back(std::thread(thread_func)); to threads.emplace_back(thread_func); Signed-off-by: Sergey Kopienko <[email protected]> * Fix includes order Signed-off-by: Sergey Kopienko <[email protected]> --------- Signed-off-by: Sergey Kopienko <[email protected]>
|
@AnuyaWelling2801 Could you please extract this two typical peace of code in your test into some functions? for(int i=0;i<n_threads;i++){
threads.emplace_back(thread_func);
} for(auto& thread : threads){
thread.join();
}There are a lot of this code... |
|
@AnuyaWelling2801 another question: if (!pass)
{
std::cout << "ERROR: did not select expected resources\n";
return 1;
}in the function The question: should we continue test is it's happen ( |
|
CI is red... |
|
|
||
| class Barrier { | ||
| public: | ||
| explicit Barrier(std::size_t count) : threshold(count), count(count), generation(0) {} |
There was a problem hiding this comment.
I think we will have incorrect work here if count == 0 or threshold == 0.
I believe assert may help to check this.
| std::condition_variable condition; | ||
| std::size_t threshold; | ||
| std::size_t count; | ||
| std::size_t generation; |
There was a problem hiding this comment.
Suggested change
| std::size_t generation; | |
| std::size_t generation = 0; |
|
|
||
| class Barrier { | ||
| public: | ||
| explicit Barrier(std::size_t count) : threshold(count), count(count), generation(0) {} |
There was a problem hiding this comment.
Suggested change
| explicit Barrier(std::size_t count) : threshold(count), count(count), generation(0) {} | |
| explicit Barrier(std::size_t count) : threshold(count), count(count) {} |
| void arrive_and_wait() { | ||
| std::unique_lock<std::mutex> lock(mutex); | ||
| auto gen = generation; | ||
| if (--count == 0) { |
There was a problem hiding this comment.
What if count == 0 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Parallel tests for
More to be added either in this PR or a separate PR