Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slack information as a way to contact oneDPL developers. #1635

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

timmiesmith
Copy link
Contributor

@timmiesmith timmiesmith commented Jun 24, 2024

This PR addresses the following items in the oneDPL migration to UXL Foundation governance:
uxlfoundation/open-source-working-group#6
uxlfoundation/open-source-working-group#11
uxlfoundation/open-source-working-group#31

@@ -37,7 +37,10 @@ You can find oneDPL samples at the [oneDPL Samples](https://github.com/oneapi-sr
## Support and Contribution
Please report issues and suggestions via [GitHub issues](https://github.com/oneapi-src/oneDPL/issues).

You can also contact oneDPL developers via [UXL Foundation Slack](https://slack-invite.uxlfoundation.org/) using
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To satisfy uxlfoundation/open-source-working-group#6 , do we need to name the specific people who are monitoring the channel here in this PR, or is it enough to have assigned this? It seems we may need to name the people here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally there is a table similar to the one here listing resposible maintainers for different parts of the project. https://github.com/oneapi-src/oneDNN/blob/main/MAINTAINERS.md

You don't need to say who is monitoring the Slack specifically so long as someone is checking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table of maintainers will be provided in a separate PR to complete the acceptance criteria for uxlfoundation/open-source-working-group#11

danhoeflinger
danhoeflinger previously approved these changes Jun 25, 2024
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmiesmith
Copy link
Contributor Author

@danhoeflinger sorry, I seem to have made a mess of this PR. Let me see if I can resolve it or need to open a new PR.

@timmiesmith
Copy link
Contributor Author

@danhoeflinger sorry, I seem to have made a mess of this PR. Let me see if I can resolve it or need to open a new PR.

Branch update issues have been resolved. One final review would be appreciated. Thank you.

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbm23
Copy link

vbm23 commented Jun 26, 2024

@ValentinaKats Requesting your review for this PR

@timmiesmith timmiesmith merged commit 71de137 into main Jun 26, 2024
20 checks passed
@timmiesmith timmiesmith deleted the add-slack-info branch June 26, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants