Addressing static analysis errors #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tatic code analysis errors.
adamfidel
previously approved these changes
Jun 25, 2024
… algorithms that may throw exceptions.
timmiesmith
dismissed stale reviews from adamfidel, danhoeflinger, and mmichel11
via
ae4745d
timmiesmith
changed the title
| @@ -104,7 +104,7 @@ __for_each_n_it_serial(_ForwardIterator __first, _Size __n, _Function __f) | |||
| //------------------------------------------------------------------------ | |||
| template <class _ForwardIterator, class _Function> | |||
| void | |||
| __brick_walk1(_ForwardIterator __first, _ForwardIterator __last, _Function __f, /*vector=*/::std::false_type) noexcept | |||
There was a problem hiding this comment.
From the CI, it looks like there is a forward declaration you also need to change.
Static analysis identified it as a violation of the Rule of Three, basically seeing the user-defined copy constructor and expecting to see corresponding user-defined assignment operator and destructor. |
|
CI issues have been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scanning oneDPL code with a static analysis tool identified the two versions of a complex comparator in the SIMD unseq backend. This PR removes the user-defined copy constructors since they are explicit versions of the default copy constructor to address the errors from the static analysis tool.
In addition the scans also identified two functions used in the implementation of uninitialized memory algorithms that were tagged with the noexcept keyword. In the case of the uninitialized memory functors new may be called, in which case an exception could be thrown.