Partially revert 1849 (refactoring changes) #1851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Sobolev <[email protected]>
lslusarczyk
previously approved these changes
Sep 17, 2024
| __storage() {} | ||
| } __values; | ||
| __range, | ||
| ([=](sycl::nd_item<1> __it)[[_ONEDPL_SYCL_REQD_SUB_GROUP_SIZE_IF_SUPPORTED(__req_sub_group_size)]] { |
There was a problem hiding this comment.
My impression was that term req_sub_group_size is already included in "_ONEDPL_SYCL_REQD_SUB_GROUP_SIZE_IF_SUPPORTED" name, therefore redundant.
But of course [[maybe-unused]] also should work, so I'm OK with the change.
There was a problem hiding this comment.
Yep, you are right. I also do not have strong opinion here. Let's then keep 16 as a literal if it is already included into _ONEDPL_SYCL_REQD_SUB_GROUP_SIZE_IF_SUPPORTED
Signed-off-by: Dmitriy Sobolev <[email protected]>
|
Closing as not relevant (the change with union was aligned with clang-format representation, let's leave it as is). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts unnecessary refactoring changes done in #1849:
uniondeclared as a one-liner in the library. Let's keep it consistent.