Use __dpl_sycl accessor in single pass scan #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Hoeflinger <[email protected]>
danhoeflinger
requested review from
timmiesmith,
dmitriy-sobolev and
adamfidel
dmitriy-sobolev
approved these changes
Sep 24, 2024
danhoeflinger
deleted the
dev/dhoeflin/fix_sycl_accessor_single_pass_scan
branch
mmichel11
pushed a commit
that referenced
this pull request
Sep 25, 2024
Signed-off-by: Dan Hoeflinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single pass scan neglects to use
__dpl_sycl::__local_accessorwhich causes problems when used with older versions of the SYCL library. This is causing some errors in the multiple translation unit tests when used with older compilers.This PR fixes that issue.