-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defining developer roles, responsibilities, and privileges and leadership process #1940
Conversation
…f role responsibilities and priviledges.
I believe RFC pull request doesn't require the all 22 CI per commit checks... Likely, only |
It should be pretty easy to put in a filter for the jobs which run tests to do one of the following:
|
@MikeDvorskiy Please see #1941 for a possible implementation of your request. |
Co-authored-by: Matthew Michel <[email protected]>
Thank you! I'll take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This largely looks good to me, other than a few minor things, and the conceptual question about usage of Milestones.
MAINTAINERS.md
Outdated
| **_Privileges_** | **Contributor** | **Code Owner** | **Maintainer** | | ||
| Permission granted | [Write][permissions] | [Write][permissions] | [Maintain][permissions] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments regarding the permissions.
First, the table says contributors have write permissions, but the detailed section for contributors mentions only read permissions.
Second, if contributors have write permissions, does it mean that this is the default permission level for anybody? Or does this assume some "process to become a contributor" that grants additional permissions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the previous discussions that we've had about Contributors being able to create branches in the repo instead of working through forks until they're a Code Owner to ease the contribution process, and that requires Write access. I think for now this should be the default for anyone and the simple process to become a contributor would be requesting write access. I've cleaned up the detailed section so it is consistent. I think in our CONTRIBUTING.md we can mention that anyone wanting to contribute may contact us via email or Slack to request write access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds reasonable. I suggest then to use "Read/Write" in the table, and in the text perhaps say that write permissions can be granted to contributors upon a request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the table and the wording in Contributor privileges. Please take a look and let me know if you have any other suggestions for the wording.
As part of the process of adopting UXL governance this PR introduces the roles developers may fill in the project and the process of moving into roles with increased responsibility and privilege. The work is based on the process defined by oneDNN and what has been proposed for oneTBB.