Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[portBLAS]Rename SYCL-BLAS to portBLAS #366

Merged
merged 1 commit into from
Sep 4, 2023
Merged

[portBLAS]Rename SYCL-BLAS to portBLAS #366

merged 1 commit into from
Sep 4, 2023

Conversation

aacostadiaz
Copy link
Contributor

@aacostadiaz aacostadiaz commented Aug 17, 2023 •
edited
Loading

This PR changes the name of SYCL-BLAS to portBLAS.

  • Do all unit tests pass locally? Attach a log. (Test Results.html.zip)
  • Have you formatted the code using clang-format?

@aacostadiaz aacostadiaz marked this pull request as draft August 17, 2023 14:55
@aacostadiaz aacostadiaz changed the title [DRAFT][SYCL-BLAS]Rename SYCL-BLAS to portBLAS [portBLAS]Rename SYCL-BLAS to portBLAS Aug 23, 2023
@aacostadiaz aacostadiaz marked this pull request as ready for review August 23, 2023 09:32
muhammad-tanvir-1211
muhammad-tanvir-1211 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@muhammad-tanvir-1211 muhammad-tanvir-1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

andrewtbarker
andrewtbarker approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@andrewtbarker andrewtbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, thanks!

@muhammad-tanvir-1211 muhammad-tanvir-1211 merged commit bd6be15 into oneapi-src:develop Sep 4, 2023
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
@aacostadiaz @normallytangent
Rename SYCL-BLAS to portBLAS (oneapi-src#366)
feef442 
Renamed the SYCL based BLAS backend to portBLAS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkrainiuk mkrainiuk mkrainiuk approved these changes

@andrewtbarker andrewtbarker andrewtbarker approved these changes

@muhammad-tanvir-1211 muhammad-tanvir-1211 muhammad-tanvir-1211 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aacostadiaz @mkrainiuk @andrewtbarker @muhammad-tanvir-1211