Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coarse provider #715

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Sep 9, 2024

Description

A memory provider that can provide memory from:

  1. a given pre-allocated buffer (the fixed-size memory provider option) or
  2. from an additional upstream provider (e.g. provider that does not support the free() operation
    like the File memory provider or the DevDax memory provider - see below).

This is a continuation of #378

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

include/umf/providers/provider_coarse.h Outdated Show resolved Hide resolved
include/umf/providers/provider_coarse.h Outdated Show resolved Hide resolved
test/disjointCoarseMallocPool.cpp Outdated Show resolved Hide resolved
include/umf/providers/provider_coarse.h Outdated Show resolved Hide resolved
@ldorau ldorau force-pushed the new_coarse_provider branch 7 times, most recently from c449180 to 9f24a85 Compare September 10, 2024 08:14
@ldorau ldorau mentioned this pull request Sep 10, 2024
10 tasks
@ldorau ldorau force-pushed the new_coarse_provider branch 2 times, most recently from aadf63e to 8ca2486 Compare September 10, 2024 16:04
@ldorau ldorau force-pushed the new_coarse_provider branch 4 times, most recently from 7e98dcb to c832101 Compare September 16, 2024 10:02
@ldorau ldorau marked this pull request as ready for review September 16, 2024 10:03
@ldorau ldorau requested a review from a team as a code owner September 16, 2024 10:03
@ldorau ldorau force-pushed the new_coarse_provider branch 9 times, most recently from 46e2b90 to 9f61dc2 Compare September 18, 2024 13:55
src/provider/provider_coarse.c Show resolved Hide resolved
src/provider/provider_coarse.c Outdated Show resolved Hide resolved
src/provider/provider_coarse.c Outdated Show resolved Hide resolved
@ldorau
Copy link
Contributor Author

ldorau commented Oct 2, 2024

you do not destroy it in this function in case of error

@lplewa Done

@ldorau ldorau requested a review from lplewa October 2, 2024 14:28
@ldorau
Copy link
Contributor Author

ldorau commented Oct 2, 2024

@lplewa ALL issues fixed - please re-review :-)

@ldorau ldorau force-pushed the new_coarse_provider branch 7 times, most recently from 8334765 to 1025a84 Compare October 3, 2024 14:03
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
include/umf/providers/provider_coarse.h Outdated Show resolved Hide resolved
include/umf/providers/provider_coarse.h Outdated Show resolved Hide resolved
include/umf/providers/provider_coarse.h Outdated Show resolved Hide resolved
include/umf/providers/provider_coarse.h Outdated Show resolved Hide resolved
src/provider/provider_coarse.c Outdated Show resolved Hide resolved
src/provider/provider_coarse.c Outdated Show resolved Hide resolved
src/provider/provider_coarse.c Outdated Show resolved Hide resolved
src/provider/provider_coarse.c Outdated Show resolved Hide resolved
src/provider/provider_coarse.c Show resolved Hide resolved
@ldorau ldorau force-pushed the new_coarse_provider branch 3 times, most recently from ffb06cd to 7adceea Compare October 4, 2024 12:21
@ldorau
Copy link
Contributor Author

ldorau commented Oct 4, 2024

All issues fixed, please resolve them and do not submit new ones ;-) - at least before the weekend ;-) and the best way to do that is just to merge it ;-)

@ldorau
Copy link
Contributor Author

ldorau commented Oct 4, 2024

Code freeze, only critical issues will be fixed ;-)

@ldorau ldorau requested a review from bratpiorka October 4, 2024 15:24
src/provider/provider_coarse.c Outdated Show resolved Hide resolved
src/provider/provider_coarse.c Outdated Show resolved Hide resolved
src/provider/provider_coarse.c Outdated Show resolved Hide resolved
Add Coarse provider - a memory provider that can manage a memory
(i.e. handle the alloc() and free() ops) of a given pre-allocated
buffer or of an additional upstream provider (e.g. OS Memory Provider
or providers that do not support the free() operation,
like the file memory provider and the DevDax memory provider).

Co-developed-by: Rafał Rudnicki <[email protected]>
Co-developed-by: Lukasz Dorau <[email protected]>

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau
Copy link
Contributor Author

ldorau commented Oct 5, 2024

@lplewa @lukaszstolarczuk All issues fixed, please resolve them all.

@bratpiorka bratpiorka merged commit ade200a into oneapi-src:main Oct 7, 2024
72 checks passed
@ldorau ldorau deleted the new_coarse_provider branch October 7, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants