add memspace filter functions #743
Open
+400
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lplewa
force-pushed
the
filter
branch
3 times, most recently
from
5bd462c
to
e20ea81
Compare
bratpiorka
requested changes
Sep 20, 2024
bratpiorka
reviewed
Sep 20, 2024
lplewa
force-pushed
the
filter
branch
2 times, most recently
from
10880c3
to
fd6a18a
Compare
bratpiorka
approved these changes
Sep 24, 2024
ldorau
requested changes
Sep 24, 2024
include/umf/memspace.h
Outdated
| umf_result_t umfMemspaceClone(umf_const_memspace_handle_t hMemspace, | ||
| umf_memspace_handle_t *hNewMemspace); | ||
|
|
||
| /// \brief custom filter function for umfMemspaceUserFilter |
include/umf/memspace.h
Outdated
Comment on lines
145
to
147
| /// \param hMemspace handle to memspace | ||
| /// \param hMemtarget handle to memory target | ||
| /// \param args - user provided arguments |
There was a problem hiding this comment.
Please use dashes - always or never in all places
| umf_result_t umfMemspaceFilterById(umf_memspace_handle_t hMemspace, | ||
| unsigned *ids, size_t size); | ||
|
|
||
| /// \brief Filters out memory targets that capacity is less than specified size. |
There was a problem hiding this comment.
so maybe umfMemspaceFilterByCapacityLT ?
There was a problem hiding this comment.
i don't know..... I do not like this LT. Looks to much like assert.
src/libumf.def.in
Outdated
| umfMemtargetGetCapacity | ||
| umfMemspaceFilterByCapacity | ||
| umfMemspaceFilterById | ||
| umfMemspaceNew |
There was a problem hiding this comment.
umfMemspaceNew should be moved after umfMemspaceMemtargetRemove
src/libumf.map.in
Outdated
| umfMemspaceCreateFromNumaArray; | ||
| umfMemspaceDestroy; | ||
| umfMemspaceFilterByCapacity; | ||
| umfMemspaceFilterById; | ||
| umfMemspaceNew; |
src/memspace.c
Outdated
| } | ||
|
|
||
| size_t *targetCapacity = args; | ||
| return capacity >= *targetCapacity ? 1 : 0; |
There was a problem hiding this comment.
Maybe (capacity >= *targetCapacity) ? 1 : 0; ?
src/memspace.c
Outdated
| filter_by_id_args_t args = {ids, size}; | ||
| int ret = umfMemspaceFilterHelper(memspace, &filterById, &args); | ||
|
|
||
| // if umfMemspaceFilter() returned negative umf_result change it to positive |
|
|
||
| TEST_F(numaNodesCapacityTest, CapacityFilter) { | ||
| if (capacities.size() <= 1) { | ||
| GTEST_SKIP() << "Not enough numa nodes"; |
There was a problem hiding this comment.
"Not enough numa nodes - skipping the test ... "
test/memspaces/memspace_numa.cpp
Outdated
|
|
||
| TEST_F(numaNodesTest, idfilter) { | ||
| if (nodeIds.size() <= 1) { | ||
| GTEST_SKIP() << "Not enough numa nodes"; |
test/memspaces/memspace_numa.cpp
Outdated
|
|
||
| TEST_F(numaNodesTest, customfilter) { | ||
| if (nodeIds.size() <= 1) { | ||
| GTEST_SKIP() << "Not enough numa nodes"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist