fix: substitute UT_ASSERTs with asserts from GTEST part 5 #744
+54
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,7 @@ permissions: | |||
|
|
|||
| env: | |||
| # for installation testing - it should match with version set in CMake | |||
| UMF_VERSION: 0.9.0 | |||
| UMF_VERSION: 0.10.0 | |||
There was a problem hiding this comment.
please rebase, Lukasz's commit should not belong here.
| @@ -42,7 +42,14 @@ std::vector<int> get_available_cpus() { | |||
| CPU_ZERO(mask); | |||
|
|
|||
| int ret = sched_getaffinity(0, sizeof(cpu_set_t), mask); | |||
| UT_ASSERTeq(ret, 0); | |||
|
|
|||
There was a problem hiding this comment.
pls describe in commit message what's really changed here - it seems like changing UT_ASSERTs is again, just a small addition 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a part of a major fix, which will be provided in multiple files.
Ref. #569
Description
Checklist