Add test if FSDAX is mapped with the MAP_SYNC flag #748
+236
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Add_test_if_FSDAX_is_mapped_with_the_MAP_SYNC_flag
branch
3 times, most recently
from
526f96c
to
04539e3
Compare
bratpiorka
requested changes
Sep 23, 2024
| @@ -121,6 +121,45 @@ static void test_alloc_failure(umf_memory_provider_handle_t provider, | |||
|
|
|||
| // TESTS | |||
|
|
|||
| // Test checking if FSDAX was mapped with the MAP_SYNC flag: | |||
There was a problem hiding this comment.
please move this comment to is_mapped_with_MAP_SYNC definition
ldorau
force-pushed
the
Add_test_if_FSDAX_is_mapped_with_the_MAP_SYNC_flag
branch
2 times, most recently
from
dc7580a
to
e927135
Compare
ldorau
force-pushed
the
Add_test_if_FSDAX_is_mapped_with_the_MAP_SYNC_flag
branch
3 times, most recently
from
de9cc57
to
8478e1d
Compare
pbalcer
approved these changes
Sep 24, 2024
Rename devdax.yml to dax.yml and add info about FSDAX. Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_test_if_FSDAX_is_mapped_with_the_MAP_SYNC_flag
branch
from
8478e1d
to
64de550
Compare
|
@bratpiorka @lukaszstolarczuk re-review please |
lukaszstolarczuk
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test if FSDAX is mapped with the
MAP_SYNCflagChecklist