Add threshold to proxy lib to call system allocator #883
+203
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Add_threshold_to_proxy_lib_to_call_system_allocator
branch
10 times, most recently
from
8bfade2
to
2a5fb9e
Compare
ldorau
changed the title
ldorau
force-pushed
the
Add_threshold_to_proxy_lib_to_call_system_allocator
branch
from
2a5fb9e
to
4cdba02
Compare
ldorau
force-pushed
the
Add_threshold_to_proxy_lib_to_call_system_allocator
branch
from
4cdba02
to
0d3f0c7
Compare
Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
Do not assert(ptr) in umfMemoryTrackerGetAllocInfo(), return UMF_RESULT_ERROR_INVALID_ARGUMENT instead. Replace LOG_WARN() with LOG_DEBUG().
Add utils_env_var_get_str() to utils_common. Use utils_env_var_get_str() inside utils_env_var_has_str() and utils_is_running_in_proxy_lib(). Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_threshold_to_proxy_lib_to_call_system_allocator
branch
from
0d3f0c7
to
7c781ef
Compare
bratpiorka
reviewed
Nov 12, 2024
| UMF_PROXY="size.threshold=128" | ||
| UMF_LOG="level:debug;flush:debug;output:stderr;pid:yes" | ||
| LD_PRELOAD=./lib/libumf_proxy.so | ||
| ctest --output-on-failure -E provider_file_memory_ipc |
There was a problem hiding this comment.
we should have a test where you use umfPoolByPtr() to check allocs smaller than threshold were not registered in the tracker
There was a problem hiding this comment.
I will add a test for that
bratpiorka
requested changes
Nov 12, 2024
Signed-off-by: Lukasz Dorau <[email protected]>
Add a size threshold to proxy lib to call system allocator when the size is less than the given threshold. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_threshold_to_proxy_lib_to_call_system_allocator
branch
from
7c781ef
to
db760b2
Compare
lplewa
requested changes
Nov 13, 2024
src/proxy_lib/proxy_lib.c
Outdated
Comment on lines
309
to
417
| if (Proxy_pool) { | ||
| if (!was_called_from_umfPool && Proxy_pool && | ||
| (umfPoolByPtr(ptr) == Proxy_pool)) { | ||
| was_called_from_umfPool = 1; | ||
| void *new_ptr = umfPoolRealloc(Proxy_pool, ptr, size); | ||
| was_called_from_umfPool = 0; | ||
| return new_ptr; | ||
| } | ||
|
|
||
| assert(0); | ||
| if (threshold_value) { | ||
| return system_realloc(ptr, size); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add test
ptr = Malloc(threshold_value + 1)
realloc(ptr, threshold_value - 1)
and vice versa.
ptr = Malloc(threshold_value - 1)
realloc(ptr, threshold_value + 1)
Both cases check then umfPoolByPtr if it returns expected value.
(atm in this PR we are not supporting this correctly - if we increasing or decrease size of allocation thru realoc we should "realloc this allocation" to correct allocator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add threshold to proxy lib to call system allocator
when a size is less than the given threshold.
Ref: #894
Requires:
Checklist