Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #3: quit apps after 2 seconds delay #9

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

incanus
Copy link
Contributor

@incanus incanus commented Jan 17, 2023

There are a multitude of ways to accomplish this, but I thought this one was the simplest.

The current code checks in closeApplication() that the app in question has "one window", which really means that it just closed its last window.

The new code just uses the same app object that received the window destroy event (passing it) and checks it after two seconds to make sure it doesn't have any windows now. This allows the user to, say, reopen a window for the app after closing the last one, as long as it is inside of two seconds.

Two seconds seems fair to avoid any problems with, say, re-launching a manually quit app.

This also requires removing @objc from closeApplication(), where it's not clear why that was there in the first place anyway.

@incanus
Copy link
Contributor Author

incanus commented Jan 17, 2023

On second thought, this would also accomplish the same thing as #8 since the post-tab-closing delay would also see a remaining window after the tab close.

@Moolynx
Copy link

Moolynx commented Feb 10, 2023

Looks like onebadidea has stopped updating this app. @incanus Is there anyway, I could download the fixes you applied? I am not a programmer, so it has to be compiled app.

@onebadidea onebadidea merged commit 0a666c1 into onebadidea:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants