unbuffered channels on bundle upload #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is still a sketch: more needs to be done by way of error-handling in particular. also, the implementation needs to be cleaned up with regard to memory usage, keeping #171 in mind. |
ransomw1c
force-pushed
the
i171-bundlepack--wip
branch
from
fcdcf9d
to
cc78441
Compare
ransomw1c
changed the title
kerneltime
approved these changes
Jun 24, 2019
Signed-off-by: Ransom Williams <[email protected]>
ransomw1c
force-pushed
the
i171-bundlepack--wip
branch
from
cc78441
to
2d45337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch is comparable to diff #167 towards iss #152 regarding concurrency patterns, specifically the preference for using unbuffered channels.
unlike #167 , this implementation additionally allows for limits on concurrency (number of files being uploaded at a time).