add store filter for collection to load correct tax_class_id when called in admin area #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multisite architecture is implemented and tax_class_id is set per website. The global tax_class_id is sent to avatax.
Added a store filter for both functions
OnePica_AvaTax_Model_Service_Avatax_Invoice::invoice()andOnePica_AvaTax_Model_Service_Avatax_Invoice::creditmemo()to set up the correct store_id instead of the admin store.The bug doesn't appear when estimating tax because the right front store will be set automatically (
see Mage_Catalog_Model_Resource_Product_Collection ::_prepareProductLimitationFilters())