Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Modularization: Switch to oni-core-redux #2284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Jun 4, 2018

This splits out the redux folder into a separate npm package. There are several pieces of functionality that depend on creating a redux store (and we use the RequestAnimationFrameBatcher in all of them, for performance). Since this is now a separate package, other features that need a redux store could be factored out into a module or a plugin, and just pick up a dependency on this module.

@codecov
Copy link

codecov bot commented Jun 5, 2018

Codecov Report

Merging #2284 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2284      +/-   ##
==========================================
- Coverage   37.36%   37.23%   -0.13%     
==========================================
  Files         298      294       -4     
  Lines       12283    12256      -27     
  Branches     1612     1609       -3     
==========================================
- Hits         4589     4563      -26     
  Misses       7444     7444              
+ Partials      250      249       -1
Impacted Files Coverage Δ
browser/src/UI/Shell/Shell.tsx 67.5% <100%> (ø) ⬆️
browser/src/Services/Language/LanguageStore.ts 95.83% <100%> (ø) ⬆️
browser/src/Services/Menu/Menu.ts 22.05% <100%> (ø) ⬆️
...er/src/Services/Notifications/NotificationStore.ts 85% <100%> (ø) ⬆️
...r/src/Services/WindowManager/WindowManagerStore.ts 58.33% <100%> (ø) ⬆️
browser/src/Services/Sidebar/SidebarStore.ts 13.43% <100%> (ø) ⬆️
browser/src/Services/Completion/CompletionStore.ts 69.06% <100%> (ø) ⬆️
browser/src/Services/Sneak/SneakStore.ts 95.65% <100%> (ø) ⬆️
...owser/src/Editor/NeovimEditor/NeovimEditorStore.ts 61.53% <100%> (ø) ⬆️
...ices/SyntaxHighlighting/SyntaxHighlightingStore.ts 26.31% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0051335...c2d2317. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant