Midi race #321
Merged
Midi race #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visualizer hangs somewhere in the midi code if the LCD is updated just before reconnect_ports(). It is still possible to for it to hang and this can be tracked down later, but it doesn't hang as often. Signed-off-by: Jason Wessel <[email protected]>
Everytime the playback device selection was used a new RtMidi endpoint was created. Using the connect all after this was causing completely erattic behavior such as loops and lag. The old endpoints must be deleted before creating new endpoints. The connectall() should also restore the input and output endpoints for the light bar. Signed-off-by: Jason Wessel <[email protected]>
If the main thread was calling inport.poll() at the time it is closed the visualizer will hang. Change the close calls to come after the new port is created and wait 2ms if it is a port reconnect operation to allow the poll operation to complete. Signed-off-by: Jason Wessel <[email protected]>
|
I tested it and it seems to be working fine, but I have never encountered any major problems with ports, so I can't really tell if it solves issues like those mentioned here |
scaraude
pushed a commit
to scaraude/Piano-LED-Visualizer
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rtpmidid series is for two specific problems:
When switching the playback device or input device,
the device endpoints must be destroyed or it ends up creating loops.
After this commit the behavior changes slightly. Previously
the piano and another source could both be inputs to the light bar
at the same time if you selected one after the other in the menu
because a new end point was created each time. But this also
caused the problem described above. The light bar should only
be connected to one source at a time.
The inport and playback port are not protected by a mutex, which
means some care needs to be taken to wait for the main thread to
not be using either resource when performing connect operations
by the web server thread.