Merge pull request #175 from online-go/svg_optimizations

Svg optimizations
online-go · Sep 4, 2024 · fecc41e · fecc41e
2 parents 1aaaa51 + ccfb173
commit fecc41e
Show file tree

Hide file tree

Showing 9 changed files with 3,717 additions and 1,807 deletions.
diff --git a/engine/package.json b/engine/package.json
@@ -1,6 +1,6 @@
 {
     "name": "goban-engine",
-    "version": "8.3.31",
+    "version": "8.3.32",
     "description": "",
     "main": "build/goban-engine.js",
     "types": "build/engine/index.d.ts",

diff --git a/examples/main.tsx b/examples/main.tsx
@@ -47,7 +47,7 @@ try {
 Goban.setCallbacks({
     getSelectedThemes: () => ({
         "board": "Kaya",
-        //board: "Anime",
+        //"board": "Anime",
 
         "white": "Plain",
         "black": "Plain",
@@ -376,8 +376,8 @@ function ReactGoban<GobanClass extends Goban>(
 
         let i = 0;
         const start = Date.now();
-        //const NUM_MOVES = 300;
-        const NUM_MOVES = 20;
+        const NUM_MOVES = 300;
+        // const NUM_MOVES = 20;
         const interval = setInterval(() => {
             i++;
             if (i >= NUM_MOVES) {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "goban",
-    "version": "8.3.31",
+    "version": "8.3.32",
     "description": "",
     "main": "build/goban.js",
     "types": "build/src/index.d.ts",

diff --git a/src/Goban.styl b/src/Goban.styl
@@ -102,16 +102,6 @@
             box-shadow: 0px 2px 10px 0px rgba(0, 0, 0, 0.16);
         }
     }
-
-    /* SVG */
-    svg {
-        text {
-            font-family: Verdana, Arial, sans-serif;
-            text-anchor: middle;
-            font-weight: bold;
-            user-select: none;
-        }
-    }
 }
 
 
diff --git a/src/Goban/Goban.ts b/src/Goban/Goban.ts
@@ -58,7 +58,7 @@ export abstract class Goban extends OGSConnectivity {
 
     protected abstract setTheme(themes: GobanSelectedThemes, dont_redraw: boolean): void;
 
-    protected parent!: HTMLElement;
+    public parent!: HTMLElement;
     private analysis_scoring_color?: "black" | "white" | string;
     private analysis_scoring_last_position: { i: number; j: number } = { i: NaN, j: NaN };
 

diff --git a/src/Goban/InteractiveBase.ts b/src/Goban/InteractiveBase.ts
@@ -239,8 +239,8 @@ export abstract class GobanInteractive extends GobanBase {
     protected display_width?: number;
     protected done_loading_review: boolean = false;
     protected dont_draw_last_move: boolean;
-    protected last_move_radius: number;
-    protected circle_radius: number;
+    public last_move_radius: number;
+    public circle_radius: number;
     protected edit_color?: "black" | "white";
     protected errorHandler: (e: Error) => void;
     protected heatmap?: NumberMatrix;
@@ -274,7 +274,7 @@ export abstract class GobanInteractive extends GobanBase {
     protected shift_key_is_down: boolean;
     //protected show_move_numbers: boolean;
     protected show_variation_move_numbers: boolean;
-    protected square_size: number = 10;
+    public square_size: number = 10;
     protected stone_placement_enabled: boolean;
     protected sendLatencyTimer?: ReturnType<typeof niceInterval>;