Bump cmake minimum required version to 3.20.0 #2064
Conversation
This matches the current minimum required version in llvm (see https://reviews.llvm.org/D144509) Signed-off-by: Stella Stamenova <[email protected]>
|
LGTM, although somewhat painful as described in the linked issue. |
|
Unfortunately Ubuntu Focal, which our dev docker image is based on, is only up to cmake 3.16.3. |
How are we going to address that once we try to update llvm to a commit that requires 3.20? |
|
I will have to look into upgrading the base image to Jammy, which will have cmake 3.22.1. |
@gongsu832 Ok, I will leave this PR up to be completed once the base image supports it. I am not sure when (though I suspect very soon) LLVM will re-commit the new version requirement and one of the next llvm updates will need this. |
|
Another option is to add the apt.kitware repo to the docker image setup. That might be lower friction until you are ready to move to jammy. |
|
I'll try Jammy and see how many things break and proceed with it if not too many. Otherwise I'll look into apt.kitware. Thanks for the suggestion. |
|
@sstamenova I'm wondering, if we upgrade our base image to Jammy, we will have to also upgrade the LLVM no-warning buildbot to Jammy, right? Since the buildbot config is supposed to match our build env. |
Yes, whichever way you use to upgrade cmake here will need to be applied to the buildbot since it will also require the newer version of cmake. |
I tried Jammy and it was eventless. Everything pretty much just worked. So I will put out a PR to upgrade to Jammy. Once that's done, can I just create another Jammy based docker container for the LLVM no-warning buildbot, replicating all the configurations from the Focal based buildbot, and then shutting down the Focal based buildbot? |
Assuming you connect with the same worker name and password, it should work. |
Great. I'll give that a shot once we upgrade to Jammy. Thanks. |
|
@jenkins-droid test this please |
|
@gongsu832 it looks like the CMake version on the Jenkins builds is still below 3.20. Is there an additional step we should take to update these? Thanks! |
|
It's being addressed by #2234 @NathanielMcVicar Windows CI appears to be stuck not reporting status. Is there any way to trigger it manually? |
I see it reporting currently, can you point me to an example? Sorry, I missed this on Friday. |
|
@gongsu832 are the conditions that were holding us to a lower cmake minimum version still holding us at this time? |
|
@gongsu832 @AlexandreEichenberger What is the current status of CMake in the docker image? |
|
I will defer this question for @gongsu832 |
|
Dev image is based on Ubuntu Jammy which comes with cmake 3.22.1 and user image is based on Redhat ubi8 which comes with cmake 3.20.2. So bumping up to 3.20.0 shouldn't be a problem. |
|
Jenkins Linux ppc64le Build #11724 [push] Bump cmake minimum requi... started at 18:16 |
|
Jenkins Linux s390x Build #12731 [push] Bump cmake minimum requi... started at 18:06 |
|
Jenkins Linux amd64 Build #12708 [push] Bump cmake minimum requi... started at 17:06 |
|
Jenkins Linux amd64 Build #12708 [push] Bump cmake minimum requi... failed after 1 hr 11 min |
|
Jenkins Linux s390x Build #12731 [push] Bump cmake minimum requi... passed after 1 hr 29 min |
|
Jenkins Linux ppc64le Build #11724 [push] Bump cmake minimum requi... passed after 1 hr 48 min |
This matches the current minimum required version in llvm (see https://reviews.llvm.org/D144509)
See #2063 as well