Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to llvm commit 8b76aea8d8b1b71f6220bc2845abc749f18a19b7 #2366

Merged
merged 8 commits into from
Jul 20, 2023

Conversation

flemairen6
Copy link
Collaborator

Green LLVM commit: 8b76aea8d8b1b71f6220bc2845abc749f18a19b7
Green MHLO commit: cae5349f85b3b2f58d80ca788e9a8695d896c3a8

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@flemairen6 flemairen6 force-pushed the ferdinand.bump_llvm_to_july_10 branch from 27b34a6 to cef52ef Compare July 12, 2023 14:09
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@philass
Copy link
Member

philass commented Jul 12, 2023

@jenkins-droid test this please

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@ttjost ttjost force-pushed the ferdinand.bump_llvm_to_july_10 branch from 5408c5f to cc04ce0 Compare July 13, 2023 10:46
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@maxbartel
Copy link
Collaborator

@jenkins-droid test this please

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@maxbartel
Copy link
Collaborator

@jenkins-droid test this please

@ttjost
Copy link
Contributor

ttjost commented Jul 14, 2023

@AlexandreEichenberger I am seeing an issue with the powerpc pipeline that relates to a recent change in llvm-exegesis. Therefore, we don't even build LLVM for it. =(
LLVM buildbots for ppc pass the test. Do you have any idea how to solve this?
The error says that __builtin_thread_pointer' is not supported on this target, but I don't have a way to reproduce this.
Thank you!

@philass
Copy link
Member

philass commented Jul 14, 2023

Ahh that looks really frustrating.

I wonder if we can play with CMake flags to not build with llvm-exegesis

@ttjost
Copy link
Contributor

ttjost commented Jul 17, 2023

Ahh that looks really frustrating.

I wonder if we can play with CMake flags to not build with llvm-exegesis

I tried doing that. This led to disabling llvm-mca, obj2yaml, and yaml2obj, but lit tests all seem to depend on them, and I get a bunch of CMake dependency errors between these tools and tests.

In any case, it turns out __builtin_thread_pointer is not supported by gcc (https://godbolt.org/z/chEnh7Ton), but works with clang (https://godbolt.org/z/c9bdTqv5f), that is why LLVM buildbots for PPC work and onnx-mlir pipelines don't.

I am somewhat blocked now, since this only happens on PPC + GCC (it seems), and everything else is green.
Should we try building an in-tree clang for it?
Could you or anyone check this, please?

@sorenlassen
Copy link
Member

sorenlassen commented Jul 17, 2023

maybe the problem has to do with this llvm code change:
llvm/llvm-project@46b5b85

but I can't think of any workaround, except build with clang as has been suggested

@AlexandreEichenberger
Copy link
Collaborator

@gongsu832

The LLVM bots succeed in building LLVM but we are not, for PPC. Reported error:

LLVM buildbots for ppc pass the test. Do you have any idea how to solve this?

Can you look into this? Is it because we use GCC to build LLVM and they are not?

@AlexandreEichenberger
Copy link
Collaborator

@flemairen6 @ttjost What about the s390 error, is it unrelated?

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@sorenlassen
Copy link
Member

@jenkins-droid test this please

@sorenlassen
Copy link
Member

@ttjost please sign-off on the last commit to fix the DCO failure

I'm not 100% sure why the jenkins pipelines fail with ERROR: Exception: java.lang.Exception: admin authentication failed, maybe it's blocked by the DCO failure?

@ttjost ttjost force-pushed the ferdinand.bump_llvm_to_july_10 branch from dc74fc5 to 220b7f7 Compare July 17, 2023 17:57
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@sorenlassen
Copy link
Member

@jenkins-droid test this please

@sorenlassen
Copy link
Member

sorenlassen commented Jul 17, 2023

@AlexandreEichenberger can you tell why the jenkins pipelines are failing with ERROR: Exception: java.lang.Exception: admin authentication failed?

update: things rebuilt without this failure once I pushed a merge commit to update the branch

@ttjost ttjost force-pushed the ferdinand.bump_llvm_to_july_10 branch from d828752 to 2a1b21d Compare July 18, 2023 07:35
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@maxbartel
Copy link
Collaborator

@jenkins-droid test this please

@gongsu832
Copy link
Collaborator

/workdir/llvm-project/llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp: In member function 'llvm::Error llvm::exegesis::{anonymous}::SubProcessFunctionExecutorImpl::createSubProcessAndRunBenchmark(llvm::StringRef, llvm::SmallVectorImpl<long int>&) const':
/workdir/llvm-project/llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp:336:61: error: '__builtin_thread_pointer' is not supported on this target
  336 |         syscall(SYS_rseq, (intptr_t)__builtin_thread_pointer() + __rseq_offset,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~^~

Apparently ppc64le does not support __builtin_thread_pointer

@AlexandreEichenberger
Copy link
Collaborator

@gongsu832

Apparently ppc64le does not support __builtin_thread_pointer

the statement was made that the ppc build in LLVM is succesfull, so either they skip this target or do something different?

@flemairen6 flemairen6 marked this pull request as ready for review July 19, 2023 07:18
Copy link
Collaborator

@maxbartel maxbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the clang PR is also already up #2379

@maxbartel
Copy link
Collaborator

@AlexandreEichenberger @philass I will merge this if the pipelines are green, the clang fix landed

@maxbartel maxbartel merged commit ab4fa45 into onnx:main Jul 20, 2023
4 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #12026 [push] Bump to llvm commit 8b76... started at 08:53

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #11020 [push] Bump to llvm commit 8b76... started at 08:59

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #12013 [push] Bump to llvm commit 8b76... started at 07:53

@AlexandreEichenberger
Copy link
Collaborator

@flemairen6 big thanks, much appreciated
@gongsu832 thanks also for your quick fix, worked perfectly

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #12013 [push] Bump to llvm commit 8b76... passed after 2 hr 2 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #12026 [push] Bump to llvm commit 8b76... passed after 3 hr 8 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #11020 [push] Bump to llvm commit 8b76... passed after 3 hr 15 min

cjvolzka added a commit to cjvolzka/onnx-mlir that referenced this pull request Jul 21, 2023
negiyas pushed a commit to negiyas/onnx-mlir that referenced this pull request Jul 31, 2023
* bump to llvm commit 8b76aea8d8b1b71f6220bc2845abc749f18a19b7

Signed-off-by: Ferdinand Lemaire <[email protected]>

* Update calls to affine::normalizeMemRefType function.

Signed-off-by: Tiago Trevisan Jost <[email protected]>

* clang-format ZHighToZLow.cpp

Signed-off-by: Tiago Trevisan Jost <[email protected]>

* Removes llvm.sext in KrnlMemcpyOpLowering that was failing in the IR verifier.

Signed-off-by: Tiago Trevisan Jost <[email protected]>

---------

Signed-off-by: Ferdinand Lemaire <[email protected]>
Signed-off-by: Tiago Trevisan Jost <[email protected]>
Co-authored-by: Tiago Trevisan Jost <[email protected]>
Co-authored-by: Philip Lassen <[email protected]>
Co-authored-by: maxbartel <[email protected]>
Co-authored-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants