Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MHLO] Lowers PadOp (constant mode) & GatherElements Op to MHLO #2377

Conversation

chenchongsong
Copy link
Contributor

This pull request lowers the following ops to MHLO:

  1. Pad op with mode as 'constant'
  2. GatherElements op

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@tungld
Copy link
Collaborator

tungld commented Jul 20, 2023

@jenkins-droid test this please

@AlexandreEichenberger
Copy link
Collaborator

FYI, on Windows, they treat many warnings as errors. This might be a simple fix... from the error logs

D:\a\1\onnx-mlir\third_party\mlir-hlo\stablehlo\stablehlo\dialect\Base.cpp(392): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\a\1\onnx-mlir\third_party\mlir-hlo\stablehlo\stablehlo\dialect\Base.cpp(392): note: while calling the constructor 'mlir::FailureOr<mlir::ShapedType>::FailureOr(T &&)'
        with
        [
            T=mlir::ShapedType
        ]

@AlexandreEichenberger
Copy link
Collaborator

@chenchongsong I believe the error should be an easy one to fix.

@Connor-XY
Copy link
Contributor

I will help with this one

@AlexandreEichenberger
Copy link
Collaborator

Should this PR be closed because functionality has been taken over by #2602?

@Connor-XY
Copy link
Contributor

Should this PR be closed because functionality has been taken over by #2602?

@AlexandreEichenberger Yes, please close this if possible. Chongsong is away and may not be able to close it promptly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants