Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Do-not-merge][NNPA] Donot check sequence_lens in lowering ONNX to ZHigh #2442

Closed
wants to merge 2 commits into from
Closed

[Do-not-merge][NNPA] Donot check sequence_lens in lowering ONNX to ZHigh #2442

wants to merge 2 commits into from

Conversation

tungld
Copy link
Collaborator

@tungld tungld commented Aug 15, 2023

This is just for testing lowering GRU to ZHigh without checking sequence_lens

@tungld
Copy link
Collaborator Author

tungld commented Aug 15, 2023

FYI @cjvolzka

@AlexandreEichenberger
Copy link
Collaborator

Is there a way to determine if/when this is legal? Maybe if the size difference still fit in the 4K lower dim padded memory?

@AlexandreEichenberger AlexandreEichenberger marked this pull request as draft August 16, 2023 13:23
@tungld
Copy link
Collaborator Author

tungld commented Sep 22, 2023

closing this since #2479 and #2501 can handle sequence_lens.

@tungld tungld closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tungld @AlexandreEichenberger @cjvolzka