Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grew windows CI timeout #2511

Merged
merged 2 commits into from
Sep 17, 2023
Merged

grew windows CI timeout #2511

merged 2 commits into from
Sep 17, 2023

Conversation

sorenlassen
Copy link
Member

@sorenlassen sorenlassen commented Sep 15, 2023 •
edited
Loading

see @jcwchen advice in issue #2481

@sorenlassen sorenlassen mentioned this pull request Sep 15, 2023
Open
@sorenlassen
Copy link
Member Author

with windows-2022 I encountered this error in step "Install onnx-mlir" in Windows-CI.yml

-- Build files have been written to: D:/a/1/onnx-mlir/build
ninja: error: 'C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'Release/bin/onnx-mlir.exe', missing and no known rule to make it

any suggestions how to overcome this are welcome

jcwchen
jcwchen reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the reason is the CI directly used cached llvm with windows-2022? However, that cached llvm was built with windows-2019. Building llvm from scratch with windows-2022 in this PR might help.

@sorenlassen sorenlassen force-pushed the slassen/windows-timeout-and-vmimage branch 2 times, most recently from 8e2e00d to 76cd1e3 Compare September 15, 2023 21:40
@sorenlassen
Copy link
Member Author

Building llvm from scratch with windows-2022 in this PR might help.

ok, I changed $mlir_tag to not use the windows-2019 artifacts but then it fails building llvm-project:

[183/4217] Building IntrinsicsLoongArch.h...
FAILED: include/llvm/IR/IntrinsicsLoongArch.h D:/a/1/llvm-project/build/include/llvm/IR/IntrinsicsLoongArch.h 
cmd.exe /C "cd /D D:\a\1\llvm-project\build && D:\a\1\llvm-project\build\bin\llvm-min-tblgen.exe -gen-intrinsic-enums -intrinsic-prefix=loongarch -I D:/a/1/llvm-project/llvm/include/llvm/IR -ID:/a/1/llvm-project/build/include -ID:/a/1/llvm-project/llvm/include D:/a/1/llvm-project/llvm/include/llvm/IR/Intrinsics.td --write-if-changed -o include/llvm/IR/IntrinsicsLoongArch.h -d include/llvm/IR/IntrinsicsLoongArch.h.d"

it looks like llvm-min-tblgen.exe fails but I don't know what goes wrong or how to overcome that

jcwchen
jcwchen reviewed Sep 16, 2023
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found the latest llvm is still using windows-2019 in its CI: https://github.com/llvm/llvm-project/blob/bce6c53464c115f5f83a57284e409b1db8c2b03f/.github/workflows/llvm-project-tests.yml#L40-L42 and so it might not be compatible with newer windows-2022. Sorry I should confirm it earlier and thank you for trying it out. I guess the least thing we can do right now is simply increasing the timeout a bit?

@sorenlassen sorenlassen force-pushed the slassen/windows-timeout-and-vmimage branch from 76cd1e3 to 704b680 Compare September 16, 2023 17:52
@sorenlassen sorenlassen changed the title grew windows CI timeout and upgraded vmImage grew windows CI timeout Sep 16, 2023
@sorenlassen
Copy link
Member Author

Sorry I should confirm it earlier and thank you for trying it out.

no problem

I guess the least thing we can do right now is simply increasing the timeout a bit?

ok, I reverted the vmImage upgrade from this PR - please approve if you agree with the change

I would love if you can find another solution to make the Windows CI run faster - it is typically the slowest of the CI pipelines and therefore slows down onnx-mlir development

@sorenlassen sorenlassen mentioned this pull request Sep 16, 2023
Closed
@sorenlassen sorenlassen force-pushed the slassen/windows-timeout-and-vmimage branch from 550a5c2 to 922c521 Compare September 17, 2023 17:42
@sorenlassen sorenlassen merged commit 5cc8cb1 into onnx:main Sep 17, 2023
4 checks passed
@sorenlassen sorenlassen deleted the slassen/windows-timeout-and-vmimage branch September 17, 2023 19:04
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #12689 [push] grew windows CI timeout ... started at 14:05

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #12712 [push] grew windows CI timeout ... started at 15:05

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #11705 [push] grew windows CI timeout ... started at 15:14

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #12689 [push] grew windows CI timeout ... failed after 1 hr 9 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #12712 [push] grew windows CI timeout ... aborted after 1 hr 29 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #11705 [push] grew windows CI timeout ... aborted after 1 hr 29 min

sorenlassen added a commit to sorenlassen/onnx-mlir-einsum that referenced this pull request Oct 2, 2023
@sorenlassen
increase Windows CI timeout again
2bd2f10 
because the latest LLVM bump in PR onnx#2545 exceeded the 4.5h timeout

see PR onnx#2511 for more context

Signed-off-by: Soren Lassen <[email protected]>
@sorenlassen sorenlassen mentioned this pull request Oct 2, 2023
Merged
sorenlassen added a commit that referenced this pull request Oct 4, 2023
@sorenlassen @AlexandreEichenberger
increase Windows CI timeout again (#2546)
31f6f59 
because the latest LLVM bump in PR #2545 exceeded the 4.5h timeout

see PR #2511 for more context

Signed-off-by: Soren Lassen <[email protected]>
Co-authored-by: Alexandre Eichenberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sorenlassen @jenkins-droid @jcwchen