-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RunONNXModel.py] Add options to print out input/output signatures and support big models #2982
Conversation
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, that is super useful. Is there a need to distinguish between input and output? I would have imagined that a common --print-signatures
would have been enough. That way, it would also reduce the increasingly long list of options.
Also, a small pet peeve: the old -save-so
accepted a directory, and would automatically "name" the .so; but the -load-so
needed an explicit so
file. Ideally, the behavior should be identical for both save and load, with my preference going to being able to name a directory in both cases. If the final behavior could be explicit in the "help" that would be good.
Signed-off-by: Tung D. Le <[email protected]>
I merged two options into a single one
Yes, both new |
Jenkins Linux amd64 Build #15889 [push] [RunONNXModel.py] Add op... started at 03:23 |
Jenkins Linux ppc64le Build #14919 [push] [RunONNXModel.py] Add op... started at 04:37 |
Jenkins Linux s390x Build #15892 [push] [RunONNXModel.py] Add op... started at 04:23 |
Jenkins Linux amd64 Build #15889 [push] [RunONNXModel.py] Add op... passed after 2 hr 6 min |
Jenkins Linux s390x Build #15892 [push] [RunONNXModel.py] Add op... passed after 2 hr 13 min |
Jenkins Linux ppc64le Build #14919 [push] [RunONNXModel.py] Add op... passed after 3 hr 46 min |
This patch improves RunONNXModel.py script with the following changes:
--print-input-signature
and--print-output-signature
to print out signatures.model.so
andmodel.constants.bin