Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First try python 3.13t #6621

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

First try python 3.13t #6621

wants to merge 3 commits into from

Conversation

andife
Copy link
Member

@andife andife commented Jan 5, 2025

Description

First try python 3.13t

Motivation and Context

@andife andife requested a review from a team as a code owner January 5, 2025 09:06
Copy link

codecov bot commented Jan 5, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
4784 3 4781 3171
View the top 3 failed tests by shortest run time
onnx.test.helper_test.TestHelperTensorFunctions::test_make_bfloat16_tensor_raw
Stack Traces | 0.001s run time
onnx/test/helper_test.py:588: in test_make_bfloat16_tensor_raw
    np.testing.assert_allclose(
.../Library/Frameworks/PythonT.framework/Versions/3.13/lib/python3.13t/contextlib.py:85: in inner
    return func(*args, **kwds)
E   AssertionError: 
E   Not equal to tolerance rtol=0.0001, atol=0
E   
E   Mismatched elements: 10 / 10 (100%)
E   Max absolute difference among violations: 32704
E   Max relative difference among violations: inf
E    ACTUAL: array([[16256, 16384],
E          [16448, 16512],
E          [15820, 15819],...
E    DESIRED: array([[0, 0],
E          [0, 0],
E          [0, 0],...
onnx.test.numpy_helper_test.TestNumpyHelper::test_to_array_from_array_043_METADATA_PROPS_FIELD_NUMBER
Stack Traces | 0.001s run time
.../Library/Frameworks/PythonT.framework/Versions/3.13/lib/python3.13t.../site-packages/parameterized/parameterized.py:620: in standalone_func
    return func(*(a + p.args), **p.kwargs, **kw)
onnx/test/numpy_helper_test.py:646: in test_to_array_from_array
    self._to_array_from_array(value)
onnx/test/numpy_helper_test.py:622: in _to_array_from_array
    self.assertEqual(list(tp.raw_data), list(again.raw_data))
E   AssertionError: Lists differ: [0, 0, 128, 63, 0, 192, 64, 64] != [0, 0, 0, 0, 0, 0, 0, 0]
E   
E   First differing element 2:
E   128
E   0
E   
E   - [0, 0, 128, 63, 0, 192, 64, 64]
E   + [0, 0, 0, 0, 0, 0, 0, 0]
onnx.test.numpy_helper_test.TestNumpyHelper::test_to_array_from_array_000_BFLOAT16
Stack Traces | 0.002s run time
.../Library/Frameworks/PythonT.framework/Versions/3.13/lib/python3.13t.../site-packages/parameterized/parameterized.py:620: in standalone_func
    return func(*(a + p.args), **p.kwargs, **kw)
onnx/test/numpy_helper_test.py:646: in test_to_array_from_array
    self._to_array_from_array(value)
onnx/test/numpy_helper_test.py:622: in _to_array_from_array
    self.assertEqual(list(tp.raw_data), list(again.raw_data))
E   AssertionError: Lists differ: [0, 0, 128, 63, 0, 192, 64, 64] != [0, 0, 0, 0, 0, 0, 0, 0]
E   
E   First differing element 2:
E   128
E   0
E   
E   - [0, 0, 128, 63, 0, 192, 64, 64]
E   + [0, 0, 0, 0, 0, 0, 0, 0]

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@andife
Copy link
Member Author

andife commented Jan 5, 2025

We probably have to wait for python-cffi/cffi#126

Signed-off-by: Andreas Fehlner <[email protected]>
@andife andife added the run release CIs Use this label to trigger release tests in CI label Jan 5, 2025
@andife andife temporarily deployed to testpypi_onnxweekly January 5, 2025 14:20 — with GitHub Actions Inactive
@andife andife changed the title Update main.yml First try python 3.13t First try python 3.13t Jan 6, 2025
@justinchuby
Copy link
Contributor

Looks promising!

@justinchuby
Copy link
Contributor

I will create a PR to fix the tests

@justinchuby
Copy link
Contributor

#6631

@justinchuby justinchuby added this to the 1.18 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome run release CIs Use this label to trigger release tests in CI
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants