-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor with black #1009
Merged
Merged
Refactor with black #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
xadupre
added a commit
to xadupre/sklearn-onnx
that referenced
this pull request
Aug 1, 2023
* Refactor with black Signed-off-by: Xavier Dupre <[email protected]> * remove unnecessary skip condition Signed-off-by: Xavier Dupre <[email protected]> * freeze lightgbm version Signed-off-by: Xavier Dupre <[email protected]> * add ruff to github action Signed-off-by: Xavier Dupre <[email protected]> * update badge on README.md Signed-off-by: Xavier Dupre <[email protected]> --------- Signed-off-by: Xavier Dupre <[email protected]>
xadupre
added a commit
that referenced
this pull request
Aug 1, 2023
* Fix converter for DecisionTreeClassifier if n_classses == 1 Signed-off-by: Xavier Dupre <[email protected]> * list or np.array Signed-off-by: Xavier Dupre <[email protected]> * lint Signed-off-by: Xavier Dupre <[email protected]> * froze lightgbm version Signed-off-by: Xavier Dupre <[email protected]> * black Signed-off-by: Xavier Dupre <[email protected]> * Refactor with black (#1009) * Refactor with black Signed-off-by: Xavier Dupre <[email protected]> * remove unnecessary skip condition Signed-off-by: Xavier Dupre <[email protected]> * freeze lightgbm version Signed-off-by: Xavier Dupre <[email protected]> * add ruff to github action Signed-off-by: Xavier Dupre <[email protected]> * update badge on README.md Signed-off-by: Xavier Dupre <[email protected]> --------- Signed-off-by: Xavier Dupre <[email protected]> * fix old CI Signed-off-by: Xavier Dupre <[email protected]> --------- Signed-off-by: Xavier Dupre <[email protected]> Signed-off-by: Xavier Dupré <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black became the standard.