Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression bug that transpose optimizer doesn't work as expected. #2313

Closed
wants to merge 4 commits into from
Closed

Fix a regression bug that transpose optimizer doesn't work as expected. #2313

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9395632
Update the condition to check output node's consumers.
fatcat-z Mar 11, 2024
c01ee28
Merge branch 'main' into issue_2300
fatcat-z Mar 11, 2024
037cd90
Merge branch 'main' into issue_2300
xadupre Jun 11, 2024
db56d34
Merge branch 'main' into issue_2300
fatcat-z Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tf2onnx/optimizer/transpose_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,14 +511,15 @@ def _add_handler(self, trans, node):
return True
return self._handle_node_having_branches(trans, node)

def _output_node_has_single_consumer_node(self, node):
def _output_has_no_multiple_consumers(self, node):
output_node = self._g.get_node_by_name(node.output[0])
return output_node and output_node.output and self._nodes_has_single_consumer_node([output_node])
return True if output_node is None \
else (output_node.output and self._nodes_has_single_consumer_node([output_node]))

def _transpose_handler(self, trans, node):
perm = trans.get_attr_value("perm")
perm_inv = invert_perm(perm)
if is_tranpose_of_type(node, perm_inv) and self._output_node_has_single_consumer_node(node):
if is_tranpose_of_type(node, perm_inv) and self._output_has_no_multiple_consumers(node):
for g in {self._g, node.graph}:
g.replace_all_inputs(node.output[0], trans.input[0]) # ops=g.get_nodes()

Expand Down
Loading