Skip to content

Commit

Permalink
Fix/remove issue references
Browse files Browse the repository at this point in the history
Signed-off-by: Jeremy Fowers <[email protected]>
  • Loading branch information
jeremyfowers committed Dec 1, 2023
1 parent e825501 commit ce84bc2
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 12 deletions.
2 changes: 1 addition & 1 deletion models/torchvision/skip/ssdlite320_mobilenet_v3_large.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

# Skip reason: triggers a bug in analysis where two models are discovered during
# profiling instead of one.
# Reinstate this model once https://github.com/onnx/turnkeyml/issues/239 is fixed
# Reinstate this model once https://github.com/onnx/turnkeyml/issues/22 is fixed


# Models discovered during profiling:
Expand Down
2 changes: 1 addition & 1 deletion src/turnkeyml/analyze/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def populate_onnx_model_info(onnx_model) -> Dict:
)
except ValueError:
# Models >2GB on disk cannot have their model size measured this
# way and will throw a ValueError https://github.com/onnx/turnkeyml/issues/318
# way and will throw a ValueError https://github.com/onnx/turnkeyml/issues/41
pass

return result_dict
Expand Down
3 changes: 0 additions & 3 deletions src/turnkeyml/cli/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -432,9 +432,6 @@ def check_extension(choices, file_name):
help="Commands for managing the models",
)

# Design note: the `models` command is simple right now, however some additional ideas
# are documented in https://github.com/onnx/turnkeyml/issues/247

models_subparsers = models_parser.add_subparsers(
title="models",
help="Commands for managing the models",
Expand Down
3 changes: 0 additions & 3 deletions src/turnkeyml/common/labels.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ def to_dict(label_list: List[str]) -> Dict[str, List[str]]:
label_value = label_value.split(",")
label_dict[label_key] = label_value
except ValueError:
# FIXME: Create a proper warning for this once we have the right
# infrastructure for doing so.
# https://github.com/onnx/turnkeyml/issues/55
printing.log_warning(
(
f"Malformed label {item} found. "
Expand Down
4 changes: 0 additions & 4 deletions test/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,10 @@ def assert_success_of_builds(
check_perf: bool = False,
check_opset: Optional[int] = None,
check_iteration_count: Optional[int] = None,
runtime: str = "ort",
check_onnx_file_count: Optional[int] = None,
) -> int:
# Figure out the build name by surveying the build cache
# for a build that includes test_script_name in the name
# TODO: simplify this code when
# https://github.com/onnx/turnkeyml/issues/16
# is done
builds = filesystem.get_all(cache_dir)
builds_found = 0

Expand Down

0 comments on commit ce84bc2

Please sign in to comment.