-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major cleanup #197
Merged
Merged
Major cleanup #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfowers
commented
Jul 18, 2024
danielholanda
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well
ramkrishna2910
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I was able test locally on my system.
Added a minor comment.
Co-authored-by: Daniel Holanda <[email protected]> Signed-off-by: Jeremy Fowers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #196 #193 #183 #182
Summary
load-build
Tool andturnkeyml.state.load_state()
APIload-build
tool takes aBUILD_NAME_state.yaml
file as input, loads the state of that build, a passes it to the next Tool in the sequence.--skip-policy
argument to make it easy to manage evaluation of large amounts of builds, similar to the skip policy in the oldturnkey cache benchmark
.ignition
module has been removed--rebuild
CLI argument has been removedturnkey cache benchmark
Tool has been removedturnkey -i path/to/state.yaml load-build benchmark
build_model()
API has been removedTool
classes directly; Create examples for the new way of using the API #198 will add examples of thisbuild_model()
have been removedbenchmark_files()
API has been renamed toevaluate_files()
Sequence
andTools
should write tostats
. All code in theevaluate_files()
body has been moved underSequence.launch()
.Sequence.launch()
does everything needed to manage the sequence, such as launching the monitor. This used to be the responsibility ofevaluate_files()
.FirstTool
, has been added to provide convenience and guardrails forTools
that are meant to start a sequence, such asload-build
,load-onnx
, anddiscover
.exp.SkipBuild
exception: any changes tostats
are rewound to before that build was loaded, such that skipping a build does not perturb the stats in any way.