Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the performance module and Device class under the run module #215

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

jeremyfowers
Copy link
Collaborator

@jeremyfowers jeremyfowers commented Aug 12, 2024

Imports from performance.py, such as class Device, where only happening within the run module. This PR moves performance.py under run/ to align the codebase to how it is being used.

This PR also allows plugins to install their own benchmark Tool that overrides the built-in one.

Copy link
Collaborator

@ramkrishna2910 ramkrishna2910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jeremyfowers jeremyfowers merged commit 0449b54 into main Aug 12, 2024
6 checks passed
@jeremyfowers jeremyfowers deleted the jfowers/move_perf branch August 12, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants