-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move run submodule out into the new devices
plugin
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfowers
commented
Aug 27, 2024
jeremyfowers
changed the title
Refresh5
Move run submodule out into the new Aug 27, 2024
devices
plugin
danielholanda
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only added a few non-blocking suggestions.
Signed-off-by: Jeremy Fowers <[email protected]>
Signed-off-by: Jeremy Fowers <[email protected]>
Signed-off-by: Jeremy Fowers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the contents of
turnkeyml.run
into an optional plugin calledturnkeyml_plugin_devices
. That plugin must be installed to gain access to thebenchmark
Tool.Design notes:
example_combined
andexample_rt
example plugins have been removed because, now, they were just essentially examples of how to add content toturnkeyml_plugin_devices
. That seemed really unnecessary sinceturnkeyml_plugin_devices
has 3 self-contained examples of how to add content (onnxrt, torchrt, tensorrt).