Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional system_info #246

Merged
merged 14 commits into from
Dec 20, 2024
Merged

Added additional system_info #246

merged 14 commits into from
Dec 20, 2024

Conversation

amd-pworfolk
Copy link
Contributor

Added collection of additional data for system_info, and updated method to collect Python package versions.

Closes #245

Copy link
Collaborator

@ramkrishna2910 ramkrishna2910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

src/turnkeyml/common/build.py Outdated Show resolved Hide resolved
src/turnkeyml/common/build.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@amd-pworfolk amd-pworfolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved by migrating from wmic to wmi package.

@amd-pworfolk
Copy link
Contributor Author

The new system_info code is now passing all the tests, including linux. If you have access to a linux box or WSL, would you please run the new file I created, src/turnkeyml/common/system_info.py, as a script and check that the output looks good on those platforms. Thanks!

@ramkrishna2910 ramkrishna2910 merged commit 8b691e6 into onnx:main Dec 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture additional system info
3 participants