Merge pull request #8 from TEAM-PREAT/chore/apply-spotless

[chore/apply-spotless] Integrate spotless with ktlint and update CI configuration

.github/workflows/ci_check.yml

@@ -0,0 +1,31 @@
+name: Check CI
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+  workflow_dispatch:
+
+concurrency:
+  group: ci-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  code-formatting-and-tests:
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup JDK 17
+        uses: actions/setup-java@v4
+        with:
+          java-version: 17
+          distribution: zulu
+          cache: gradle
+
+      - name: Check Spotless
+        run: ./gradlew spotlessCheck
+
+      - name: Run Common Tests
+        run: ./gradlew cleanAllTests allTests

build.gradle.kts

@@ -5,7 +5,7 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
 
 plugins {
     id("root.publication")
-    //trick: for the same plugin versions in all sub-modules
+    // trick: for the same plugin versions in all sub-modules
     alias(libs.plugins.androidApplication).apply(false)
     alias(libs.plugins.androidLibrary).apply(false)
     alias(libs.plugins.kotlinAndroid).apply(false)

convention-plugins/build.gradle.kts

@@ -4,4 +4,4 @@ plugins {
 
 dependencies {
     implementation(libs.nexus.publish)
-}
+}

convention-plugins/settings.gradle.kts

@@ -18,4 +18,4 @@ dependencyResolutionManagement {
             from(files("../gradle/libs.versions.toml"))
         }
     }
-}
+}

convention-plugins/src/main/kotlin/module.publication.gradle.kts

@@ -11,15 +11,21 @@ publishing {
     // Configure all publications
     publications.withType<MavenPublication> {
         // Stub javadoc.jar artifact
-        artifact(tasks.register("${name}JavadocJar", Jar::class) {
-            archiveClassifier.set("javadoc")
-            archiveAppendix.set(this@withType.name)
-        })
+        artifact(
+            tasks.register("${name}JavadocJar", Jar::class) {
+                archiveClassifier.set("javadoc")
+                archiveAppendix.set(this@withType.name)
+            },
+        )
 
         // Provide artifacts information required by Maven Central
         pom {
             name.set("peekaboo")
-            description.set("Kotlin Multiplatform library for Compose Multiplatform, designed for seamless integration of an image picker feature in iOS and Android applications.")
+            description.set(
+                "Kotlin Multiplatform library for Compose Multiplatform, " +
+                    "designed for seamless integration of an image picker feature in iOS " +
+                    "and Android applications.",
+            )
             url.set("https://github.com/TEAM-PREAT/peekaboo")
 
             licenses {
@@ -61,4 +67,4 @@ signing {
 tasks.withType<AbstractPublishToMaven>().configureEach {
     val signingTasks = tasks.withType<Sign>()
     mustRunAfter(signingTasks)
-}
+}

peekaboo-image-picker/src/androidMain/kotlin/com/preat/peekaboo/image/picker/ByteArrayToImageBitmap.android.kt

@@ -6,4 +6,4 @@ import androidx.compose.ui.graphics.asImageBitmap
 
 actual fun ByteArray.toImageBitmap(): ImageBitmap {
     return BitmapFactory.decodeByteArray(this, 0, size).asImageBitmap()
-}
+}

peekaboo-image-picker/src/androidMain/kotlin/com/preat/peekaboo/image/picker/ImagePicker.kt

@@ -18,8 +18,9 @@ internal fun isSystemPickerAvailable(): Boolean {
 }
 
 @SuppressLint("NewApi", "ClassVerificationFailure")
-internal fun getMaxItems() =  if (isSystemPickerAvailable()) {
-    MediaStore.getPickImagesMaxLimit()
-} else {
-    Integer.MAX_VALUE
-}
+internal fun getMaxItems() =
+    if (isSystemPickerAvailable()) {
+        MediaStore.getPickImagesMaxLimit()
+    } else {
+        Integer.MAX_VALUE
+    }

peekaboo-image-picker/src/androidMain/kotlin/com/preat/peekaboo/image/picker/ImagePickerLauncher.android.kt

@@ -16,15 +16,17 @@ actual fun rememberImagePickerLauncher(
     onResult: (List<ByteArray>) -> Unit,
 ): ImagePickerLauncher {
     return when (selectionMode) {
-        SelectionMode.Single -> pickSingleImage(
-            selectionMode = selectionMode,
-            onResult = onResult
-        )
+        SelectionMode.Single ->
+            pickSingleImage(
+                selectionMode = selectionMode,
+                onResult = onResult,
+            )
 
-        is SelectionMode.Multiple -> pickMultipleImages(
-            selectionMode = selectionMode,
-            onResult = onResult
-        )
+        is SelectionMode.Multiple ->
+            pickMultipleImages(
+                selectionMode = selectionMode,
+                onResult = onResult,
+            )
     }
 }
 
@@ -35,27 +37,28 @@ private fun pickSingleImage(
 ): ImagePickerLauncher {
     val context = LocalContext.current
 
-    val singleImagePickerLauncher = rememberLauncherForActivityResult(
-        contract = ActivityResultContracts.PickVisualMedia(),
-        onResult = { uri ->
-            uri?.let {
-                with(context.contentResolver) {
-                    openInputStream(uri)?.use {
-                        onResult(listOf(it.readBytes()))
+    val singleImagePickerLauncher =
+        rememberLauncherForActivityResult(
+            contract = ActivityResultContracts.PickVisualMedia(),
+            onResult = { uri ->
+                uri?.let {
+                    with(context.contentResolver) {
+                        openInputStream(uri)?.use {
+                            onResult(listOf(it.readBytes()))
+                        }
                     }
                 }
-            }
-        }
-    )
+            },
+        )
 
     return remember {
         ImagePickerLauncher(
             selectionMode = selectionMode,
             onLaunch = {
                 singleImagePickerLauncher.launch(
-                    PickVisualMediaRequest(ActivityResultContracts.PickVisualMedia.ImageOnly)
+                    PickVisualMediaRequest(ActivityResultContracts.PickVisualMedia.ImageOnly),
                 )
-            }
+            },
         )
     }
 }
@@ -66,34 +69,37 @@ fun pickMultipleImages(
     onResult: (List<ByteArray>) -> Unit,
 ): ImagePickerLauncher {
     val context = LocalContext.current
-    val maxSelection = if (selectionMode.maxSelection == INFINITY) {
-        getMaxItems()
-    } else {
-        selectionMode.maxSelection
-    }
+    val maxSelection =
+        if (selectionMode.maxSelection == INFINITY) {
+            getMaxItems()
+        } else {
+            selectionMode.maxSelection
+        }
 
-    val multipleImagePickerLauncher = rememberLauncherForActivityResult(
-        contract = ActivityResultContracts.PickMultipleVisualMedia(maxSelection),
-        onResult = { uriList ->
-            val imageBytesList = uriList.mapNotNull { uri ->
-                context.contentResolver.openInputStream(uri)?.use { inputStream ->
-                    inputStream.readBytes()
+    val multipleImagePickerLauncher =
+        rememberLauncherForActivityResult(
+            contract = ActivityResultContracts.PickMultipleVisualMedia(maxSelection),
+            onResult = { uriList ->
+                val imageBytesList =
+                    uriList.mapNotNull { uri ->
+                        context.contentResolver.openInputStream(uri)?.use { inputStream ->
+                            inputStream.readBytes()
+                        }
+                    }
+                if (imageBytesList.isNotEmpty()) {
+                    onResult(imageBytesList)
                 }
-            }
-            if (imageBytesList.isNotEmpty()) {
-                onResult(imageBytesList)
-            }
-        }
-    )
+            },
+        )
 
     return remember {
         ImagePickerLauncher(
             selectionMode = selectionMode,
             onLaunch = {
                 multipleImagePickerLauncher.launch(
-                    PickVisualMediaRequest(ActivityResultContracts.PickVisualMedia.ImageOnly)
+                    PickVisualMediaRequest(ActivityResultContracts.PickVisualMedia.ImageOnly),
                 )
-            }
+            },
         )
     }
 }

peekaboo-image-picker/src/commonMain/kotlin/com/preat/peekaboo/image/picker/ByteArrayToImageBitmap.kt

@@ -2,4 +2,4 @@ package com.preat.peekaboo.image.picker
 
 import androidx.compose.ui.graphics.ImageBitmap
 
-expect fun ByteArray.toImageBitmap(): ImageBitmap
+expect fun ByteArray.toImageBitmap(): ImageBitmap

peekaboo-image-picker/src/commonMain/kotlin/com/preat/peekaboo/image/picker/ImagePickerLauncher.kt

@@ -7,20 +7,22 @@ import kotlinx.coroutines.CoroutineScope
 expect fun rememberImagePickerLauncher(
     selectionMode: SelectionMode = SelectionMode.Single,
     scope: CoroutineScope?,
-    onResult: (List<ByteArray>) -> Unit
+    onResult: (List<ByteArray>) -> Unit,
 ): ImagePickerLauncher
 
 sealed class SelectionMode {
     data object Single : SelectionMode()
+
     data class Multiple(val maxSelection: Int = INFINITY) : SelectionMode()
+
     companion object {
         const val INFINITY = 0
     }
 }
 
 expect class ImagePickerLauncher(
     selectionMode: SelectionMode,
-    onLaunch: () -> Unit
+    onLaunch: () -> Unit,
 ) {
     fun launch()
-}
+}

peekaboo-image-picker/src/iosMain/kotlin/com/preat/peekaboo/image/picker/ByteArrayToImageBitmap.ios.kt

@@ -4,5 +4,4 @@ import androidx.compose.ui.graphics.ImageBitmap
 import androidx.compose.ui.graphics.toComposeImageBitmap
 import org.jetbrains.skia.Image
 
-actual fun ByteArray.toImageBitmap(): ImageBitmap =
-    Image.makeFromEncoded(this).toComposeImageBitmap()
+actual fun ByteArray.toImageBitmap(): ImageBitmap = Image.makeFromEncoded(this).toComposeImageBitmap()

peekaboo-image-picker/src/iosMain/kotlin/com/preat/peekaboo/image/picker/ImagePickerLauncher.ios.kt

@@ -21,33 +21,36 @@ import platform.posix.memcpy
 actual fun rememberImagePickerLauncher(
     selectionMode: SelectionMode,
     scope: CoroutineScope?,
-    onResult: (List<ByteArray>) -> Unit
+    onResult: (List<ByteArray>) -> Unit,
 ): ImagePickerLauncher {
-
     @OptIn(ExperimentalForeignApi::class)
-    val delegate = object : NSObject(), PHPickerViewControllerDelegateProtocol {
-        override fun picker(picker: PHPickerViewController, didFinishPicking: List<*>) {
-            picker.dismissViewControllerAnimated(flag = true, completion = null)
-            @Suppress("UNCHECKED_CAST")
-            val results = didFinishPicking as List<PHPickerResult>
+    val delegate =
+        object : NSObject(), PHPickerViewControllerDelegateProtocol {
+            override fun picker(
+                picker: PHPickerViewController,
+                didFinishPicking: List<*>,
+            ) {
+                picker.dismissViewControllerAnimated(flag = true, completion = null)
+                @Suppress("UNCHECKED_CAST")
+                val results = didFinishPicking as List<PHPickerResult>
 
-            for (result in results) {
-                result.itemProvider.loadDataRepresentationForTypeIdentifier(
-                    typeIdentifier = "public.image"
-                ) { nsData, _ ->
-                    scope?.launch(Dispatchers.Main) {
-                        val data = mutableListOf<ByteArray>()
-                        nsData?.let {
-                            val bytes = ByteArray(it.length.toInt())
-                            memcpy(bytes.refTo(0), it.bytes, it.length)
-                            data.add(bytes)
+                for (result in results) {
+                    result.itemProvider.loadDataRepresentationForTypeIdentifier(
+                        typeIdentifier = "public.image",
+                    ) { nsData, _ ->
+                        scope?.launch(Dispatchers.Main) {
+                            val data = mutableListOf<ByteArray>()
+                            nsData?.let {
+                                val bytes = ByteArray(it.length.toInt())
+                                memcpy(bytes.refTo(0), it.bytes, it.length)
+                                data.add(bytes)
+                            }
+                            onResult(data.toList())
                         }
-                        onResult(data.toList())
                     }
                 }
             }
         }
-    }
 
     return remember {
         ImagePickerLauncher(
@@ -57,31 +60,35 @@ actual fun rememberImagePickerLauncher(
                 UIApplication.sharedApplication.keyWindow?.rootViewController?.presentViewController(
                     pickerController,
                     true,
-                    null
+                    null,
                 )
-            }
+            },
         )
     }
 }
 
 private fun createPHPickerViewController(
     delegate: PHPickerViewControllerDelegateProtocol,
-    selection: SelectionMode
+    selection: SelectionMode,
 ): PHPickerViewController {
-    val pickerViewController = PHPickerViewController(
-        configuration = when (selection) {
-            is SelectionMode.Multiple -> PHPickerConfiguration().apply {
-                setSelectionLimit(selectionLimit = selection.maxSelection.toLong())
-                setFilter(filter = PHPickerFilter.imagesFilter)
-                setSelection(selection = PHPickerConfigurationSelectionOrdered)
-            }
-            SelectionMode.Single -> PHPickerConfiguration().apply {
-                setSelectionLimit(selectionLimit = 1)
-                setFilter(filter = PHPickerFilter.imagesFilter)
-                setSelection(selection = PHPickerConfigurationSelectionOrdered)
-            }
-        }
-    )
+    val pickerViewController =
+        PHPickerViewController(
+            configuration =
+                when (selection) {
+                    is SelectionMode.Multiple ->
+                        PHPickerConfiguration().apply {
+                            setSelectionLimit(selectionLimit = selection.maxSelection.toLong())
+                            setFilter(filter = PHPickerFilter.imagesFilter)
+                            setSelection(selection = PHPickerConfigurationSelectionOrdered)
+                        }
+                    SelectionMode.Single ->
+                        PHPickerConfiguration().apply {
+                            setSelectionLimit(selectionLimit = 1)
+                            setFilter(filter = PHPickerFilter.imagesFilter)
+                            setSelection(selection = PHPickerConfigurationSelectionOrdered)
+                        }
+                },
+        )
     pickerViewController.delegate = delegate
     return pickerViewController
 }
@@ -93,4 +100,4 @@ actual class ImagePickerLauncher actual constructor(
     actual fun launch() {
         onLaunch()
     }
-}
+}