Adding compression quality as parameter of ResizeOption. Fixes #41. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @shtolik, overall, your contribution looks good to me – really appreciate your work on adding the JPEG compression rate along with the resize options. I've left a code review with one small request: could we add a validation check to ensure that the compression quality value remains between 0 and 1? If a user inputs a value above 1.0, it might lead to issues since the compression quality in JPEG format is typically defined within this range. Implementing this safeguard will help maintain the robustness of the library. |
onseok
reviewed
Jan 12, 2024
...o-image-picker/src/iosMain/kotlin/com/preat/peekaboo/image/picker/ImagePickerLauncher.ios.kt
Outdated
Show resolved
Hide resolved
...-image-picker/src/androidMain/kotlin/com/preat/peekaboo/image/picker/PeekabooImageResizer.kt
Outdated
Show resolved
Hide resolved
Adding annotation library and marking compressionQuality param as FloatRange.
|
Pushed changes fixing suggestions. |
l2hyunwoo
reviewed
Mar 7, 2024
onseok
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding compression quality as parameter of ResizeOption. Fixes #41