Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support async send with buffer size limit #1180

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

laizy
Copy link
Contributor

@laizy laizy commented Apr 28, 2020

No description provided.

}
} else {
// no buffer has been taken, yield this goroutine to avoid busy loop
runtime.Gosched()
Copy link
Member

@Honglei-Cong Honglei-Cong May 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be implemented with channel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will cause sending a notification for every msg to wake the writer, which will hurt performance in high contention scenario.

@laizy laizy changed the base branch from net-review to master May 9, 2020 10:49
@laizy laizy force-pushed the master branch 2 times, most recently from 8c8ee59 to dc599e9 Compare July 6, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants