refactor(oomstore/join): return the result instead of writing directly to the file #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinghancc
reviewed
Feb 11, 2022
jinghancc
reviewed
Feb 11, 2022
| ctx, cancel := context.WithCancel(ctx) | ||
| defer cancel() | ||
|
|
||
| func (s *OomStore) Join(ctx context.Context, opt types.JoinOpt) (*types.JoinResult, error) { |
There was a problem hiding this comment.
In this way, Go SDK will behave differently from other SDKs, is that expected?
There was a problem hiding this comment.
This makes go SDK more flexible. Because other SDKs need to go through the oomagent layer of wrappers.
As for the inconsistent behavior, I'm not quite sure of the scope of the impact, we can discuss it.
lianxmfor
force-pushed
the
refactor/oomstore-join
branch
from
fb217a4
to
90031e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR does:
GetEntityRowsFromInputFileprivate