Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(offline/export): drop temp table after export done #1194

Closed
wants to merge 1 commit into from

Conversation

lianxmfor
Copy link
Member

drop temp table after export is done.

TODO:

  1. Unify offline/export and offline/join on drop temp table functions to offline.DbOpt

fix #1193

@lianxmfor lianxmfor self-assigned this Feb 14, 2022
@wfxr wfxr self-requested a review February 14, 2022 06:44
Copy link
Member

@wfxr wfxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lianxmfor
Copy link
Member Author

lianxmfor commented Feb 14, 2022

In sync, the offline store is responsible for reading data, the online store is responsible for writing data, and the metadata store is responsible for modifying metadata. If all three stores are SQLite and use the same db file, offline delete the table and cause multiple connections to write errors: database is locked (5) (SQLITE_BUSY).

So it is better for offline to provide an interface: dropTempTable to be called by oomstore at the right time.

@lianxmfor
Copy link
Member Author

This PR can't solve the problem of multiple writes for three stores under the same SQLITE file, close.

@lianxmfor lianxmfor closed this Feb 14, 2022
@YikSanChan YikSanChan deleted the feature/offline-join-drop-temp-table branch February 14, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: export not drop temp table
2 participants