-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize the benchmark output folder #166
base: main
Are you sure you want to change the base?
Conversation
For each benchmark test case, save benchmark result in same folder. Signed-off-by: Li Gang <[email protected]>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we save benchmark result in same folder For each benchmark test case, ?
How do we know which outcome belongs to which cases?
I guess may affect the CD workflow when calculating the average latency for each test case. Please help to check~
@daisy-ycguo @chensuyue
For each case, will create one folder. For next case, will create another folder. So, we can identify the test case of the folder. For current code, for each test case, will create MULTIPLE folders, one folder for each "user_queries" item. After applied my PR, it will create one folder, and put 4 queries' results into this folder, make it easy to compare and report.
|
@chensuyue Can you help to confirm please? Does the CD flow depend on current folder structure or now. |
@chensuyue, please help to confirm. |
Description
For each benchmark test case, save benchmark result in same folder.
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.