Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix to add missing BRIDGE_TOWER_EMBEDDING env var for MultimodalQnA #1280

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

dmsuehir
Copy link
Contributor

@dmsuehir dmsuehir commented Dec 20, 2024

Description

There was a recent change to combine retriever microservices in GenAIComps. There was a coordinating PR updating MultimodalQnA, however it was missing these BRIDGE_TOWER_EMBEDDING environment variables in the Intel cpu/hpu README.md and set_vars.sh files.

Issues

Without setting this env var, querying the megaservice fails. The error in the lvm-llava-svc logs are:

File "/home/user/comps/lvms/llava/lvm.py", line 57, in lvm
    img_b64_str = retrieved_metadatas[0]["b64_img_str"]
                  ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
KeyError: 'b64_img_str'

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

None

Tests

Manually tested, because the test scripts set the env vars as part of the test script, and those scripts were correctly setting the env var.

Copy link

github-actions bot commented Dec 20, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashahba ashahba merged commit 0bf1d0b into opea-project:main Dec 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants