Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] unified benchmark script for all examples under GenAIExamples #276

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ftian1
Copy link
Collaborator

@ftian1 ftian1 commented Jan 14, 2025

This RFC is used to demonstrate the enhanced design of GenAIExamples benchmark script.

Copy link

@AlexHe99 AlexHe99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that make sense to set specific GPU by [instance_num] if using k8s? It is usual to set the number of GPU to k8s and k8s will auto manager the GPU resource.

@ftian1
Copy link
Collaborator Author

ftian1 commented Jan 15, 2025

Is that make sense to set specific GPU by [instance_num] if using k8s? It is usual to set the number of GPU to k8s and k8s will auto manager the GPU resource.

it's used to provide a manual control way for user to specify the concrete config. of course we should also support auto-scale way in k8s by ignoring this field.

@poussa
Copy link

poussa commented Jan 24, 2025

Why the ´ deploy_and_benchmark` file is in the root?

@mkbhanda
Copy link
Collaborator

Why the ´ deploy_and_benchmark` file is in the root?

Because it works across all the GenAIExamples. It takes as argument the chatname.
As name suggestes, it deploys the workload specified by chartname and runs the benchmark (performance and/or accuracy) specified in the default or provided yaml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants