Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use dto in getversion #268

Closed
wants to merge 0 commits into from
Closed

feat: use dto in getversion #268

wants to merge 0 commits into from

Conversation

rjbrache
Copy link
Contributor

No description provided.

@rjbrache rjbrache marked this pull request as ready for review July 15, 2024 20:47
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 86.63968% with 33 lines in your changes missing coverage. Please review.

Project coverage is 58.24%. Comparing base (add720a) to head (2eb3a18).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/usecase/devices/certificates.go 78.57% 6 Missing ⚠️
internal/controller/http/v2/devicemanagement.go 55.55% 3 Missing and 1 partial ⚠️
internal/usecase/devices/repo.go 55.55% 4 Missing ⚠️
internal/controller/http/v1/devices.go 50.00% 3 Missing ⚠️
internal/usecase/devices/info.go 95.89% 2 Missing and 1 partial ⚠️
internal/controller/http/v1/devicemanagement.go 75.00% 2 Missing ⚠️
internal/controller/http/v1/profiles.go 50.00% 2 Missing ⚠️
internal/usecase/amtexplorer/wsman.go 0.00% 2 Missing ⚠️
internal/usecase/devices/alarms.go 77.77% 2 Missing ⚠️
internal/usecase/profilewificonfigs/usecase.go 66.66% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   56.55%   58.24%   +1.69%     
==========================================
  Files          64       64              
  Lines        4265     4323      +58     
==========================================
+ Hits         2412     2518     +106     
+ Misses       1675     1621      -54     
- Partials      178      184       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/entity/dto/version.go Outdated Show resolved Hide resolved
@rjbrache rjbrache force-pushed the dtogetversion branch 2 times, most recently from 9374f76 to 0a077aa Compare July 22, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants