Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable auth on websocket #424

Merged
merged 2 commits into from
Oct 30, 2024
Merged

feat: enable auth on websocket #424

merged 2 commits into from
Oct 30, 2024

Conversation

rsdmike
Copy link
Member

@rsdmike rsdmike commented Oct 29, 2024

No description provided.

@rsdmike rsdmike enabled auto-merge (rebase) October 29, 2024 20:13
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 15.68627% with 43 lines in your changes missing coverage. Please review.

Project coverage is 68.93%. Comparing base (ad5aa5b) to head (d12e62c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/http/v1/devices.go 7.69% 24 Missing ⚠️
internal/controller/ws/v1/redirect.go 24.00% 17 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   69.31%   68.93%   -0.39%     
==========================================
  Files          80       80              
  Lines        8946     8996      +50     
==========================================
  Hits         6201     6201              
- Misses       2430     2478      +48     
- Partials      315      317       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsdmike rsdmike merged commit ad68431 into main Oct 30, 2024
22 of 24 checks passed
@rsdmike rsdmike deleted the wsAuth branch October 30, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants